cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler" <cziege...@s-und-n.de>
Subject RE: cvs commit: cocoon-2.0/src/java/org/apache/cocoon/transformation SQLTransformer.java
Date Thu, 13 Mar 2003 14:02:47 GMT
Jeremy Quinn wrote:
> 
> Referring to my earlier post entitled "SQL error, moving from JVM 1.3.1  
> to 1.4.1"
> 
> By reverting this change:
> 
> >   -            String query = sb.toString().trim();
> >   +            String query =  
> > StringUtils.deleteWhitespace(sb.toString());
> 
> My SQL Queries work again.
> 
> I think StringUtils.deleteWhitespace is deleting ALL whitespace,  
> thereby rendering the queries invalid.
> 
Ah, that's not good!

> Was there a special reason you did this?
Yes, another bug (I don't remember the number know). The query string
can contain whitespaces that have to be filtered out, like cariage
returns etc. Ok, thinking of this, it's not that easy.

> Is there another workaround, or should I revert this patch to CVS?
Yes, revert it - we have to implement some kind of filter then.

Sorry for the inconvenience.

Carsten

Mime
View raw message