cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Turner <je...@apache.org>
Subject Re: Module Sample
Date Thu, 13 Mar 2003 15:19:20 GMT
On Thu, Mar 13, 2003 at 03:54:21PM +0100, Christian Haul wrote:
> On 14.Mar.2003 -- 01:26 AM, Jeff Turner wrote:
> > On Thu, Mar 13, 2003 at 01:44:37PM +0100, Christian Haul wrote:
> 
> > > the defaults module is superceeded by the xmlfile module.
> > 
> > Is it?  Forrest uses this:
> > 
> >  <component-instance name="defaults"
> >        class="org.apache.cocoon.components.modules.input.DefaultsMetaModule">
> >   <values>
> >     <skin>forrest-site</skin>
> >     <base-url>/forrest</base-url>
> >   </values>
> >  </component-instance>
> > 
> > Can't see how XMLFileModule replaces it. 
> 
> OK, OK, we're not going to remove it ;-) IMO the XMLFile module is
> much more versatile than the key-value pair model of the defaults
> module. Both target a very similar task, thus I felt that defaults is
> not needed anymore.

Yes, but constructing a DOM and doing a JXPath lookup is way more
expensive than Configuration.getChild(). 

Hrm.. I think DefaultsMetaModule isn't actually a meta module:

public class DefaultsMetaModule extends AbstractLogEnabled
    implements InputModule, Configurable, ThreadSafe {

Guess it should be renamed.  Just as well Cocoon is in perennial
pre-alpha :)

Btw, mind if I move that nifty XSPModuleHelper class into
o.a.c.c.modules?  It's being used in LinkRewriterTransformer now.


--Jeff


> 	Chris.
> -- 
> C h r i s t i a n       H a u l
> haul@informatik.tu-darmstadt.de
>     fingerprint: 99B0 1D9D 7919 644A 4837  7D73 FEF9 6856 335A 9E08

Mime
View raw message