cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Gallardo" <agalla...@agsoftware.dnsalias.com>
Subject [Input-xsl] - Mixing concepts between Attribute and Parameter
Date Fri, 06 Dec 2002 09:45:32 GMT
Hi.

I was currently checking the source code for the new XSP logicsheet
input.xsl. Yesterday was proposed by Piroumian to change the name of all
elements from "parameter" to "attributes". The change was correct from the
user view.

>From the developer view there are still the "old" functions names with
"parameter" concept.

I think now this is very easy to know, but maybe when someone will try to
update or extend this code will have problem with the concepts.

For example, check this comment:

<!-- parameter name, no default, required -->
    <xsl:variable name="name">
      <xsl:call-template name="get-string-attribute">
        <xsl:with-param name="name">name</xsl:with-param>
        <xsl:with-param name="required">true</xsl:with-param>
      </xsl:call-template>
    </xsl:variable>

maybe

<!-- attribute name, no default, required -->
    <xsl:variable name="name">
      <xsl:call-template name="get-string-attribute">
        <xsl:with-param name="name">name</xsl:with-param>
        <xsl:with-param name="required">true</xsl:with-param>
      </xsl:call-template>
    </xsl:variable>

Also, there are some bad functions names with "parameters":

<xsl:when test="$as = 'object'">
        <xsp:expr>this._xsp_module_helper.getParameter(objectModel,
<xsl:copy-of select="$module"/>,<xsl:copy-of
select="$name"/>,<xsl:copy-of select="$default"/>)</xsp:expr>
      </xsl:when>

Regards,

Antonio Gallardo




---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message