cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicola Ken Barozzi <nicola...@apache.org>
Subject Re: [VOTE] Make errors caught only by Cocoon.java
Date Thu, 05 Sep 2002 14:01:13 GMT

Marcus Crafter wrote:
> Hi All,
> 
> 	Hope all is well.
> 	
> 	+1 from me too, although with the example below, I'd use warn() or
> 	something appropriate to indicate that an exceptional situation
> 	has occured (unless that exception really was just for debugging).
> 	
> 	Shouldn't we also wrap our logging statements with tests before
> 	hand ?
> 	
> 	ie. instead of:
> 	
> 	getLogger().debug("some value " + value + ", some other value " + v);
> 	
> 	have:
> 	
> 	if (getLogger().isDebugEnabled()) {
> 		getLogger().debug(.....);
> 	}
> 	
> 	to save logging un-logged text ?

We should *always* do it, it is common practice... when we remember to 
do it ;-)

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message