cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicola Ken Barozzi <nicola...@apache.org>
Subject Re: 3 suggestions
Date Thu, 05 Sep 2002 13:15:00 GMT

Carsten Ziegeler wrote:
> Nicola Ken Barozzi wrote:
> 
>>Carsten Ziegeler wrote:
>>
>>>>-----Original Message-----
>>>>From: ola.berg@arkitema.se [mailto:ola.berg@arkitema.se]
>>>>Sent: Thursday, September 05, 2002 11:30 AM
>>>>To: cocoon-dev@xml.apache.org
>>>>Subject: 3 suggestions
>>>>
>>>>
>>>>3) src-path in the exceptions from the parsers
>>>>
>>>>As it stands, it is difficult to determine which of the sources 
>>>>in a pipe that the parser compains about. Isn\'t it possible to 
>>>>wrap the exceptions so that info on what part of the process that 
>>>>did fail?
>>>>
>>>
>>>Actually the exceptions are wrapped but unfortunately there is no
>>>evaluation of all possible wrapping exceptions at the top level.
>>>
>>>The logging of exceptions is an issue which comes up from time
>>>to time but has never been really solved. Currently, one single
>>>exception is logged more than once because it is logged when
>>>it is thrown, it is logged when it is rethrown and it is logged
>>>when it is catched.
>>>I made several month ago the suggestion to log exceptions only
>>>when they are catched - but not when they are thrown or rethrown.
>>>They can be logged when they are thrown/rethrown when the component
>>>is in debug mode. 
>>>This would make the logs much more cleaner and if then the evaluating
>>>code you suggest above is added at the top level, that would be cool.
>>>But unfortunately there was no agreement about this...
>>
>>Hmmm... the exceptions should cascade, so actually how-when it's 
>>rethrown should not be an issue to understand where the problem comes 
>>from, no?
>>
> 
> Yes.
> 
> But there was no consensus on if we should log when the exception is thrown
> or when it is catched and consumed (and not rethrown). I prever the last
> way and someone else prefered the first solution. So, it's still as it
> is and you get an exception logged more than once - blowing up the log.

It should be logged when it is consumed, because you can never tell if 
you catch a new exception or an already rethrown one.

BTW, do we really need to log exceptions in the components?

I would really like to see the errors caught ONLY by Cocoon.java, and 
logged there. It would reduce the problems we are having a LOT.

I have no real control on ecxeptions ATM, because of strange catching, 
rethrowing... AND PLEASE, LET'S KILL THE PROCESSINGEXCEPTIONS!

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message