cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler" <cziege...@s-und-n.de>
Subject RE: SunRise: AuthAction.java bug?
Date Fri, 09 Aug 2002 06:24:30 GMT
Ok, you're right - I fixed this.

Thanks for reporting!

Regards
Carsten

> -----Original Message-----
> From: Per Kreipke [mailto:per@onclave.com]
> Sent: Thursday, August 08, 2002 7:11 PM
> To: cocoon-dev@xml.apache.org
> Subject: RE: SunRise: AuthAction.java bug?
>
>
> Carsten,
>
> More on the code:
>
>
> > >         if (this.handlerName == null) this.handlerName = "";
> > >         if (this.applicationName == null) this.applicationName = "";
> > >         if (this.handlerName.equals(newHandlerName) == false
> > >             || this.applicationName.equals(newAppName) == false) {
> > >             this.handlerName = newHandlerName;
> > >             this.applicationName = newAppName;
> > >             this.handler = null;
> > >             this.application = null;
> > >
> > >             if (this.handlerName != null) {
> > >                 if ( null != this.userHandlers) {
> > >                     this.handler =
> > > (Handler)this.userHandlers.get(this.handlerName);
> > >                 } else {
> > >                     this.handler =
> > > (Handler)this.configuredHandlers.get(this.handlerName);
> > >                 }
> > >
> > >                 if (this.handler == null) {
> > >                     throw new ProcessingException("Handler not
> > found: " +
> > > this.handlerName);
> > >                 }
>
> What if this.handlerName is null? Then the entire block with the exception
> is skipped. E.g. if I don't define a handler (which was my original
> mistake), then newHandlerName is null and it's asigned to this.handlerName
> which is then also null.
>
> Per
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message