cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <vadim.gritse...@verizon.net>
Subject Re: cvs commit: xml-cocoon2/src/scratchpad/src/org/apache/cocoon/generation SourceDescriptionGenerator.java
Date Thu, 22 Aug 2002 14:24:02 GMT
Stephan Michels wrote:

>On Wed, 21 Aug 2002, Vadim Gritsenko wrote:
>
>  
>
>>stephan@apache.org wrote:
>>
>>    
>>
>>>stephan     2002/08/21 08:35:47
>>>
>>> Modified:    src/scratchpad/src/org/apache/cocoon/generation
>>>                       SourceDescriptionGenerator.java
>>> Log:
>>> Reduce Source lookup's.
>>>
>>>      
>>>
>>...
>>
>>    
>>
>>>  public class SourceDescriptionGenerator extends ComposerGenerator
>>> -        implements CacheableProcessingComponent{
>>> +        implements CacheableProcessingComponent, Recyclable {
>>>
>>>      
>>>
>>...
>>
>>    
>>
>>> +    /** Traversed source for the keys and validities */
>>> +    private Hashtable cachedsources = null;
>>>
>>>      
>>>
>>Stephan,
>>
>>You will end up with one or *more* *pools* of *hashtables*. Are you sure
>>you want to cache this way?
>>    
>>
>
>Thank you for the hint, I was just profiling my application, and noticed
>that with modified XMLFileDescriptorStore every request need 1200 ms, and
>that with a full cacheable pipeline.
>After solving a problem with the cache of XMLFileDescriptorStore I
>went into <100ms.
>
>Ps. I don't want to cache the Sources within the Generator, but the
>current SourceResolver doesn't handle pools of Sources.
>

May be you need pooling in the Factory of the "slow" source?

source/impl/SlowPooledSourceFactory
source/impl/SlowPooledSource

:)

Vadim


>Stephan.
>  
>


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message