cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Melhem <micha...@fztig938.bank.dresdner.net>
Subject Re: [PATCH] Patch to complete (auto) caching-point functionality
Date Fri, 09 Aug 2002 08:50:11 GMT
Hi Carsten!

Thanks for the quick application of the patch. You are a legend mate!
:-)

Intial testing shows thats everything is fine!!

However there is still a small generic problem with the pipelines at the moment. 
Namely [Bug 11131]. This patch should be applied so that caching-point 
(and other pipelines) would function at 100%

the patch is quite small.
In AbstractCachingProcessingPipeline.java


-                finished = false;
-                this.completeResponseIsCached = false;
                 // try a shorter key
                 // FIXME (CZ) calculation of PPK
                 if (cachedPipelineKey.size() > 1) {
                     cachedPipelineKey.removeLastKey();
-                    this.firstProcessedTransformerIndex--;
+		    if (!this.completeResponseIsCached) {
+                      this.firstProcessedTransformerIndex--;
+		    }
                 } else {
                     cachedPipelineKey = null;
                 }
+                finished = false;
+                this.completeResponseIsCached = false;
             }
         }
 
Many thanks,
Michael Melhem



On Fri, Aug 09, 2002 at 09:51:32AM +0200, Carsten Ziegeler wrote:
> Hi Michael,
> 
> thanks for your patch - I just applied it.
> Please cross-check if everything is working fine.
> 
> Thanks
> Carsten
> 
> > -----Original Message-----
> > From: Michael Melhem [mailto:michaelm@fztig938.bank.dresdner.net]
> > Sent: Wednesday, August 07, 2002 4:25 PM
> > To: cocoon-dev@xml.apache.org
> > Cc: sylvain.wallez@anyware-tech.com
> > Subject: Re: [PATCH] Patch to complete (auto) caching-point
> > functionality
> > 
> > 
> > Hi Sylvain,
> > 
> > Hope its not still raining where your at! :-)
> > 
> > <snip>
> > > Yes, it looks perfectly acceptable ;)
> > >
> > > Would you like to resubmit your patch this way ? I'll try to apply it
> > > from my laptop and its sloooow modem connection. If I can't, I'll ask
> > > someone else to do it (e.g. Carsten, with which IIRC you initially
> > > worked with on caching points).
> > >
> > </snip>
> > 
> > The re-worked patch is now submitted as Bugzilla [Bug 11530].
> > 
> > Thanks a lot for your time!!
> > 
> > Regards,
> > Michael Melhem
> > 
> > > Regards,
> > > Sylvain
> > >
> > > --
> > > Sylvain Wallez
> > >  Anyware Technologies                  Apache Cocoon
> > >  http://www.anyware-tech.com           mailto:sylvain@apache.org
> > >
> > >
> > >
> > >
> > >
> > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> > 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message