cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Melhem <micha...@fztig938.bank.dresdner.net>
Subject Re: [PATCH] Patch to complete (auto) caching-point functionality
Date Mon, 05 Aug 2002 08:18:21 GMT
Hi Sylvain,

> Michael,
> 
> Thanks for your work, but it can't be accepted as is : the new Pipeline method
> "informBranchPoint(ProcessingNode node)" introduces a strong dependency of
> pipelines to the treeprocessor engine that should be avoided.
> 
> This strong separation between components is not for the theroretical beauty of
> things : the switch from compiled engine to the treeprocessor couldn't have been
> possible if components had dependencies on the compiled engine...

Yes, I see your point. 

It would be infact much neater not pass the
paramterer ProcessingNode to the pipeline implementation. Actually all
the pipeline does on the node is call node.hasChildren() on it.

So....what if, In SimpleParentProcessingNode we have

        if (context.pipelineIsSet()  && this.hasChildren() ) {
            context.getProcessingPipeline().informBranchPoint();
        }

instead of

        if (context.pipelineIsSet() ) ) {
            context.getProcessingPipeline().informBranchPoint(this);
        }

That way we would require no inspection of the tree/node by the caching-point
pipeline at all (for both auto caching-point and manual pipeline-hint
caching-point). This would be a simple change.

Would that be more acceptable??

Regards,
Michael Melhem
 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message