cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vadim Gritsenko" <vadim.gritse...@verizon.net>
Subject RE: Proposed addition to RequestGenerator (diff -u patch included)
Date Wed, 07 Aug 2002 12:28:58 GMT
> From: Carsten Ziegeler [mailto:cziegeler@s-und-n.de]
> 
> Hi Ilya,
> 
> let's make a deal :) - I apply your patch and you contribute a (small)
> docu patch for the request generator doc.
> 
> Oh, I already applied it, so now it's your turn...
> 
> Thanks for your patch! I removed the reference to the XSPObjectHelper,
> please verify if everything is OK.

Carsten,

But xspExpr did much more then String.valueOf. It was working with
XMLizable, w2c.Node, Collections, etc.


PS Why do not use getParameterAsBoolean?

Vadim


> Thanks
> Carsten
> 
> > -----Original Message-----
> > From: Ilya A. Kriveshko [mailto:ilya@kaon.com]
> > Sent: Tuesday, August 06, 2002 11:46 PM
> > To: cocoon-dev@xml.apache.org
> > Subject: Proposed addition to RequestGenerator (diff -u patch
included)
> >
> >
> > Hello,
> >
> > I needed RequestGenerator to give me access not only to request
> > parameters, but also to request attributes. Attributes allow a
Request
> > object to carry a "history" of the request among other things, and
> > sometimes it is useful to have access to that history from an XPath
> > expression [like document('cocoon://httprequest')] or any other
place
> > that might use RequestGenerator.
> >
> > Attached is a small and simple patch to
> >
xml-cocoon2/src/java/org/apache/cocoon/generation/RequestGenerator.java
> > that provides just that functionality.
> >
> > In order to not adversely affect anyone who is relying on there not
> > being any extra stuff in the generated request XML, I left
attributes
> > turned off by default. They can be turned on, either at the
generator
> > definition or invocation in the sitemap by specifying <map:parameter
> > name="generate-attributes" value="true"/>.
> >
> > I need this functionality for my project, and placing it in the
> > RequestGenerator appears to be a natural choice.
> >
> > The patch that I attached has been tested under cocoon-2.1-dev
running
> > on Tomcat 3.3.1 on Win2k and Linux under JDK 1.3.1.
> >
> > Please, someone, review my changes and if I managed to convince you
of
> > their usefulness, commit them to the repository.
> > --
> > Ilya


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message