Return-Path: 
 <cocoon-dev-return-29576-apmail-xml-cocoon-dev-archive=xml.apache.org@xml.apache.org>
Delivered-To: apmail-xml-cocoon-dev-archive@xml.apache.org
Received: (qmail 63646 invoked by uid 500); 15 Jul 2002 17:46:02 -0000
Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:cocoon-dev-help@xml.apache.org>
list-unsubscribe: <mailto:cocoon-dev-unsubscribe@xml.apache.org>
list-post: <mailto:cocoon-dev@xml.apache.org>
Reply-To: cocoon-dev@xml.apache.org
Delivered-To: mailing list cocoon-dev@xml.apache.org
Received: (qmail 63541 invoked from network); 15 Jul 2002 17:46:01 -0000
Message-ID: <3D330A37.8060700@apache.org>
Date: Mon, 15 Jul 2002 19:45:27 +0200
From: Nicola Ken Barozzi <nicolaken@apache.org>
Reply-To: nicolaken@apache.org
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.0.0) Gecko/20020530
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: cocoon-dev@xml.apache.org
Subject: Re: [PROPOSAL] Extending Sitemap Error Handling
References: <Pine.LNX.4.44.0207151500360.1336-100000@lapgp.otego.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N


Giacomo Pati wrote:
> On Mon, 15 Jul 2002, Sylvain Wallez wrote:
> 
>>Giacomo Pati wrote:
>>
>>>On Wed, 10 Jul 2002, Michael Melhem wrote:
>>>
>>>
>>>>>Currently, an implicit <map:generate type="!notifying-generator!"/> is
>>>>>added as the first statement of <handle-errors> (see
>>>>>HandleErrorsNode.invoke() in treeprocessor).
>>>>>
>>>>>What about making this explicit so we can choose other generators as
>>>>>well, such as a standard file generator to display for example a nice
>>>>>"page not found" page using some site-wide stylesheets ?
>>>>>
>>>>><handle-errors>
>>>>><match type="error" pattern="not-found">
>>>>>  <generate type="file" src="notfound.xml"/>
>>>>>  <transform src="skin/doc2html.xsl"/>
>>>>>  <serialize/>
>>>>></match>
>>>>><!-- fallback -->
>>>>><generate type="notifying"/>
>>>>><transform src="system/error2html.xsl"/>
>>>>><serialize/>
>>>>></handle-errors>
>>>>>
>>>>>
>>>>I like the idea of an explicit generator in the handle-errors...but
>>>>doesnt this open up the sitemap handle-errors block for abuse?
>>>
>>>Oh god, this discussion is old as hell.
>>>
>>>http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=96942814002458&w=2
>>>
>>
>>Well, if this discussion comes again after so much time, isn't it
>>because the problem is still there ?
> 
> I'm not saying the discussion is useless. Just that it was held since
> years (almost ;).

Yeah, it was the first thing I did in alpha 1 or 2 ;-)

>>As stated in the post you refer to, "you only need one way to XML-ize
>>error information". This proposal doesn't break this, but allows people
>>to generate *something else* when the error-handler doesn't display the
>>error itself, as shown by "notfound.xml" above.
> 
> I know. The dangerous part is pointing to the implicit generator used
> ("!notifying-generator!") which is unfortunately wrong named and should be
> something like "<notifying-generator>" to prevent it being explicitely
> used ("<" are illegal characters for attributes).

Making it explicit will remove this problem.

But I agree, for backward compat we should keep the implicit one working 
(albeit with a note in the output).
So +1 from me to change the implicit generator name to 
<deprecated-implicit-notifying-generator> or similar.

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org