cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivelin Ivanov" <ive...@apache.org>
Subject Re: [Announcement] Cocoon Form Handling - XML Form Release 0.8
Date Thu, 18 Apr 2002 01:59:50 GMT

Sylvain,

----- Original Message -----
From: "Sylvain Wallez" <sylvain.wallez@anyware-tech.com>
To: <cocoon-dev@xml.apache.org>
Sent: Wednesday, April 17, 2002 4:05 PM
Subject: Re: [Announcement] Cocoon Form Handling - XML Form Release 0.8


> Ivelin Ivanov wrote:
>
> >For those who will take the time to peek in,
> >
>
> I unfortunately do not have the necessary time to peek in, but just
> tried to compile with JDK 1.3 and this failed. Please, ensure that your
> code runs on 1.3, or even 1.2 (there are still a lot of appservers
> running 1.2 on customer sites).

Thanks for the patch.
I actually did a full clean and build on my box, saw and fixed the error but
couldn't check it in before you did :)

> Also, please respect the coding standard in use for Cocoon :
> - 4 spaces indentation,
> - class attributes at the top of the class, and without a trailing
> underscore,
> - open braces at the end of lines,
> - no spaces before and after parenthesis.
>
> This may not be your current coding standard (just as it's not the one
> in use in my company), but please use it for code consistency.

Old habits, hard to change overnight. Can we do something similiar to
Andrew's suggestion?
We're doing this at the office. Human errors are inevitable.

> Remember also that JavaDoc is HTML and thus a new line in the comment
> doesn't produce a new line in the javadoc.

Will work on this.

You didn't mention if the demo ran successfully or not?

BTW, I am probably still doing something wrong with the mailing lists,
because I see your patch on the dev list, but don't see any of the files I
checked in. How do I fix that?


Cheers,

Ivelin

>
> Thanks,
> Sylvain
>
> --
> Sylvain Wallez
>  Anyware Technologies                  Apache Cocoon
>  http://www.anyware-tech.com           mailto:sylvain@apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message