Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cocoon-dev@xml.apache.org
From: "Vadim Gritsenko" <vadim.gritsenko@verizon.net>
To: <cocoon-dev@xml.apache.org>
Subject: RE: aggregate and views : what's the correct behaviour ?
Date: Fri, 22 Mar 2002 18:15:56 -0500
Message-ID: <003d01c1d1f7$856b8cf0$0a00a8c0@vgritsenkopc>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
In-Reply-To: <3C9BB9E1.40009@anyware-tech.com>
Importance: Normal

Sylvain,

You forgot one thing: Compiled engine does not work 100% correctly, see
corresponding TODO item - it's there on purpose. See also FIXME in the
documentation site sitemap.xmap which illustrates the same issue you are
describing here.

PS I thought you got my email. Or not?

Regards,
Vadim

> -----Original Message-----
> From: Sylvain Wallez [mailto:sylvain.wallez@anyware-tech.com]
> Sent: Friday, March 22, 2002 6:10 PM
> To: cocoon-dev@xml.apache.org
> Subject: map:aggregate and views : what's the correct behaviour ?
> 
> Hi team,
> 
> I just fixed a bug in the treeprocessor which was not handling views
in
> map:aggregate like the compiled engine (see
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7196). However, this
> made me wonder about what should be the correct behaviour.
> 
> Let's consider the sitemap snippet that revealed the bug (from the
docs
> sitemap) :
> 
>   <map:view name="content" from-label="content">
>    <map:serialize type="xml"/>
>   </map:view>
>   ...
>    <map:match pattern="*.html">
>     <map:aggregate element="site">
>      <map:part src="cocoon:/book-{1}.xml"/>
>      <map:part src="cocoon:/body-{1}.xml" label="content"/>
>     </map:aggregate>
>     <map:transform src="stylesheets/site2xhtml.xsl">
> 
> The label="content" on the 2nd part is used to select parts depending
on
> the view. Both implementations do that equally well, that is, when
> requesting view "content", only "body-{1}.xml" is included.
> 
> The difference was about whether a part label should imply or not a
jump
> to the view :
> - the compiled engine automatically jumps to the view as soon as one
> map:part has a corresponding label even if the map:aggregate doesn't
> have this label.
> - before fixing the bug, the interpreted engine jumped to the view
> _only_ if the map:aggregate also had a corresponding label (i.e.
> label="content" in the above snippet).
> 
> My opinion is that there are some uses case where automatic jump isn't
> good. Let's consider the following :
>   <map:view name="books" from-label="books">
>   ...
>   <map:aggregate element="root">
>     <map:part src="isbn-codes.xml" label="books"/>
>     <map:part src="authors.xml"/>
>   <map:aggregate>
>   <map:transform src="isbn2books.xsl" label="books"/>
>   <map:transform src="books2html.xsl"/>
>   <map:serialize/>
> 
> The "books" view should give the list of books. With automatic jump,
the
> above only gives a list of isbn codes and we cannot apply
> "isbn2books.xsl". On the contrary, explicit labels mean that there's
no
> jump to the view from map:aggregate and that the stylesheet is
correctly
> applied.
> 
> So, in short, my opinion is that labels of map:part should be for
> _selecting_ which parts belong to the view, and that view branching
> should depend _only_ on the labels of map:aggregate.
> 
> What is your opinion ?
> 
> Sylvain
> 
> --
> Sylvain Wallez
>  Anyware Technologies                  Apache Cocoon
>  http://www.anyware-tech.com           mailto:sylvain@apache.org
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org