Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cocoon-dev@xml.apache.org
Date: Wed, 27 Feb 2002 10:56:46 +0100 (CET)
From: Torsten Curdt <tcurdt@dff.st>
To: <cocoon-dev@xml.apache.org>
Subject: Re: esql thread unsafe - bug
In-Reply-To: 
 <Pine.LNX.4.33L2.0202270208220.17559-100000@localhost.localdomain>
Message-ID: <Pine.LNX.4.31.0202271055420.7729-100000@mogh.dff.local>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Wed, 27 Feb 2002, Donald Ball wrote:

> On Tue, 19 Feb 2002, Szymon Stasik wrote:
>
> > I've discovered serious bug in esql logicsheet while using it with
> > cocoon-1.8.3. However the same bug seems to exists in cocoon2. The
> > problem is that while node stack logic variables (xspParentNode,
> > xspCurrentNode, xspNodeStack) are defined inside populateDocument
> > method, similar objects used by esql (_esql_connections etc...) exist as
> > object attributes.
> >
> > Since there is only one instance of particular xsp page (eg.
> > _index.class) per application, under havy load it is possible (and easy
> > to observe using eg jmeter) that concurent calls to the same
> > _index.populateDocument method will lead esql structures and connection
> > pools to be corrupted.
> >
> > you can find attached the patch that should fix thing up (it works at
> > least with cocoon-1.8.x)
>
> criminy, i think you're right, and i think your patch should work. it's
> been a while since i've had a serious chance to play with this stuff; can
> an active developer sanity check this (into cvs)?

Donald, I fixed this already a few days ago :)

Thanks
--
Torsten


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org