cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sylvain Wallez <sylvain.wal...@anyware-tech.com>
Subject Re: cvs commit: xml-cocoon2/src/java/org/apache/cocoon/sitemap DefaultSitemapComponentSelector.java
Date Thu, 07 Feb 2002 08:52:37 GMT
Vadim Gritsenko wrote:

>Sylvain,
>
>How it is different from SitemapComponentSelector?
>
>Just curios...
>
>Vadim
>
It's identical :) But as the TreeProcessor has it's own 
ComponentSelector to directly handle the syntax of <map:components> as 
its configuration, I had to move the sitemap specific methods (getLabels 
and hadLabel) to a common interface. This interface is 
SitemapComponentSelector, and the previous SitemapComponentSelector has 
been moved to DefaultSitemapComponentSelector.

This means label and mime-type handling is duplicated between sitemap 
and treeprocessor selectors, which is obviously bad. A solution would be 
for the compiled sitemap to use the selector in the treeprocessor (it's 
compatible as it doesn't use the special handling of configuration), but 
this is not possible now because treeprocessor is in the scratchpad.

If treeprocessor moves to the main src trunk, some refactoring will be 
possible for common parts between the two implementations.

>>-----Original Message-----
>>From: sylvain@apache.org [mailto:sylvain@apache.org]
>>Sent: Wednesday, February 06, 2002 4:09 PM
>>To: xml-cocoon2-cvs@apache.org
>>Subject: cvs commit: xml-cocoon2/src/java/org/apache/cocoon/sitemap
>>DefaultSitemapComponentSelector.java
>>
>>sylvain     02/02/06 13:09:22
>>
>>  Added:       src/java/org/apache/cocoon/sitemap
>>                        DefaultSitemapComponentSelector.java
>>  Log:
>>  Oops, forgot to add the new file :/
>>
-- 
Sylvain Wallez
Anyware Technologies - http://www.anyware-tech.com




---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message