cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Davanum Srinivas <d...@yahoo.com>
Subject RE: cvs commit: xml-cocoon2/src/java/org/apache/cocoon/components/language/programming CompiledProgrammingLanguage.java
Date Fri, 08 Feb 2002 20:05:02 GMT
Vadim,

How about this doing the following? Will this be ok?

Defaults in cvs should be: preload = false, reload = true.
For WAR deployment the flags should be: preload = true, reload = false.

Yes, once we agree on this we can cleanup the code.

Thanks,
dims

--- Vadim Gritsenko <vadim.gritsenko@verizon.net> wrote:
> > From: Davanum Srinivas [mailto:dims@yahoo.com]
> > 
> > Vadim,
> > 
> > Please see my other email that i sent just now...
> 
> Yes, I see that you are trying to do WAR deployment...
> 
> 
> > - Am open to discussion on what the preload flag means. Am sorry if i
> tripped
> > on another "feature".
> 
> IIRC:
>  - "preload" means do not compile code on startup and load existing
> classes (if any). This is, btw, the main problem all newbies are seeing
> on the user list: Cocoon preloads old sitemap which is not compatible
> with new Cocoon after upgrade :) So, this feature *was* working already
> :)
> 
>  - "reload" means delete old class file and source file when original
> markup was changed, and re-generate all this.
> 
> Then, for WAR, you want to use 
>  preload = true
>  reload = false
> 
> And the change:
> +            if (programInstance != null && !this.preload &&
> this.autoReload) {
> 
> will break reload if preload is true. Right?
> 
> 
> > - The duplicate code is needed because even if the source code (.java)
> is
> > missing but if the classes are present in the classloader, we should
> use it.
> 
> May be you mean: *class file* is missing *but* present in the
> classloader? Then it makes sense! I do feel that something should be
> changed here... 
> 
> 
> 
> > Am open to suggestions, patches, criticism...But please try it out "-
> > Dbuild.precompile=true"
> > feature in the build script. Again, Please see my other email that i
> sent just
> > now...
> 
> Can't do this right now... Quite busy with other stuff...
> 
> Regards,
> Vadim
> 
> > 
> > Thanks,
> > dims
> 
> <snip/>
> 
> 


=====
Davanum Srinivas - http://jguru.com/dims/

__________________________________________________
Do You Yahoo!?
Send FREE Valentine eCards with Yahoo! Greetings!
http://greetings.yahoo.com

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message