cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Piroumian, Konstantin" <KPiroum...@flagship.ru>
Subject Re: [Patch] Character handling in i18n transformer fix
Date Fri, 08 Feb 2002 14:48:46 GMT
Yes, sorry, this was my fault. I used the 1.10 revision to make my changes.
Could you please replace the current version with the attached one? The
previous one is too different, cause it's implemented in another way but
does the same thing.

Hope that there were no other changes since revision 1.10, otherwise it will
require a more sophisticated merge.

Thank you again.

Konstantin

> Failed again:
>
> patching file `I18nTransformer.java'
> Hunk #1 succeeded at 629 (offset 3 lines).
> Hunk #3 succeeded at 883 (offset 3 lines).
> Hunk #5 FAILED at 1069.
> Hunk #6 FAILED at 1092.
> 2 out of 6 hunks FAILED -- saving rejects to I18nTransformer.java.rej
>
>
> Note, that method i18nCharacters looks like (in CVS version):
>     private void i18nCharacters(char[] ch, int start, int len)
>         throws SAXException {
>
>        strBuffer.append(new String(ch, start, len).trim());
>     }
>
> In the patch you have:
> @@ -1053,10 +1069,10 @@
>          }
>      }
>
> -    private void i18nCharacters(char[] ch, int start, int len)
> +    private void i18nCharacters(String textValue)
>          throws SAXException {
>
> -        String textValue = new String(ch, start, len).trim();
> +        textValue = textValue.trim();
>          if (textValue == null || textValue.length() == 0) {
>              return;
>          }
>
> These two differ a lot.
>
> Vadim
>
> > -----Original Message-----
> > From: Piroumian, Konstantin [mailto:KPiroumian@flagship.ru]
> > Sent: Friday, February 08, 2002 8:51 AM
> > To: cocoon-dev@xml.apache.org
> > Subject: Re: [Patch] Character handling in i18n transformer fix
> >
> > > Hi Konstantin,
> > >
> > > Patch failed. Can you resend diff with the currect CVS?
> >
> > Sure and thanks.
> >
> > P.S. I still can't access nagoya.apache.org - it must be something
> wrong
> > with our DNS server.
> >
> > >
> > > Thanks,
> > > Vadim
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>


Mime
View raw message