Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cocoon-dev@xml.apache.org
Content-Type: text/plain;
  charset="iso-8859-1"
From: Bertrand Delacretaz <bdelacretaz@codeconsult.ch>
Reply-To: bdelacretaz@codeconsult.ch
Organization: codeconsult
To: cocoon-dev@xml.apache.org
Subject: Re: Check Source
Date: Fri, 25 Jan 2002 12:05:55 +0100
References: 
 <CCD084B0E779D411A70300508B6622260361FA85@exchukahis02.experian.co.uk>
 <3C512FC9.12C98FDE@apache.org>
In-Reply-To: <3C512FC9.12C98FDE@apache.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <20020125110556.5905A23D09@dj.codeconsult.ch>

On Friday 25 January 2002 11:13, Stefano Mazzocchi wrote:
> . . .
> Currently we have 13000 style errors? I personally don't care.

I agree - from the feature list at http://checkstyle.sourceforge.net/, I find 
only two that (IMHO) can have a real influence on code quality, that is 

-Detecting variables that are not declared as private or protected.
-Methods/Constructors are not longer than a specified number of lines.

And even these can be counterproductive at times - writing good code takes 
much more than having spaces before typecasts or not.

The rest could influence the "reading comfort" according to your personals 
tastes, but IMHO is not relevant to the actual code quality.

Besides, good tools (netbeans for example) will reformat source code to fit 
one's personals tastes.

My 2 cents.

-- 
 -- Bertrand Delacr�taz, www.codeconsult.ch
 -- web technologies consultant - OO, Java, XML, C++


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org