Return-Path: Delivered-To: apmail-xml-cocoon-dev-archive@xml.apache.org Received: (qmail 45544 invoked by uid 500); 15 Dec 2001 11:03:27 -0000 Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: cocoon-dev@xml.apache.org Delivered-To: mailing list cocoon-dev@xml.apache.org Received: (qmail 45468 invoked from network); 15 Dec 2001 11:03:26 -0000 Message-ID: <3C1A68F7.A866F023@apache.org> Date: Fri, 14 Dec 2001 22:02:47 +0100 From: Stefano Mazzocchi X-Mailer: Mozilla 4.78 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: cocoon-dev@xml.apache.org Subject: Re: Cleaning up the CVS References: <3C176642.E2D1068A@apache.org> <20011214160629.GA22419@fztig938.bank.dresdner.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Marcus Crafter wrote: > > On Wed, Dec 12, 2001 at 03:14:26PM +0100, Stefano Mazzocchi wrote: > > > > I'm quite keen to learn of a better way to > > > ascertain this information and I'm open if you have any suggestions > > > about how to improve it ? > > > > The code seems to be collecting the maximum number of incoming > > concurrent requests. It might be useful, I don't know, but for sure it > > doesn't require synchronization. I mean: adding and subtracting one to a > > counter is an atomic operation (on ints, it's not on longs, but we don't > > have that many requests anyway). > > > > The non-atomic operation is the comparison with previous maximum. One > > possible simple solution is to have a sampling thread that reads that > > value and logs it someplace. It might be useful for profiling > > information. > > > > What do you think? > > Ok. Sounds good to me. cool. > I'll come up with a diff over the weekend. Even better. > Thanks for your suggestions. Please feel free to offer further critique > in the future, it's much appreciated. Oh, don't worry about that :) -- Stefano Mazzocchi One must still have chaos in oneself to be able to give birth to a dancing star. Friedrich Nietzsche -------------------------------------------------------------------- --------------------------------------------------------------------- To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org For additional commands, email: cocoon-dev-help@xml.apache.org