Return-Path: 
 <cocoon-dev-return-19744-apmail-xml-cocoon-dev-archive=xml.apache.org@xml.apache.org>
Delivered-To: apmail-xml-cocoon-dev-archive@xml.apache.org
Received: (qmail 6016 invoked by uid 500); 11 Dec 2001 10:53:06 -0000
Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:cocoon-dev-help@xml.apache.org>
list-unsubscribe: <mailto:cocoon-dev-unsubscribe@xml.apache.org>
list-post: <mailto:cocoon-dev@xml.apache.org>
Reply-To: cocoon-dev@xml.apache.org
Delivered-To: mailing list cocoon-dev@xml.apache.org
Received: (qmail 6005 invoked from network); 11 Dec 2001 10:53:05 -0000
Message-ID: <3C15E584.2DA017AC@anyware-tech.com>
Date: Tue, 11 Dec 2001 11:52:52 +0100
From: Sylvain Wallez <sylvain.wallez@anyware-tech.com>
Organization: Anyware Technologies
X-Mailer: Mozilla 4.7 [fr] (WinNT; I)
X-Accept-Language: fr,en
MIME-Version: 1.0
To: cocoon-dev@xml.apache.org
Subject: Re: [PATCH] Added Resource Monitor in ProgramGeneratorImpl
References: <LDEKKGCNJLEPFDOEIHFDKEEFCKAA.g-froehlich@gmx.de>
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N



Gerhard Froehlich a �crit :

<snip/>

> >
> >Gerhard,
> >
> >After studying your patch, it appears to be broken :
> >ProgramGeneratorImpl is TreadSafe and thus a single instance is used for
> >*all* compiled components. So the lastModified date stored by
> >propertyChanged() is the date of the last modified program file found by
> >the ActiveMonitor.
> >The effect is that the next program requested using load() is
> >recompiled, but it is very unlikely to be the one that was modified : an
> >unchanged program is recompiled and the changed one is not recompiled :(
> 
> Ahh Sh**. There can be more then one sitemap. I will look at it. Maybe
> we should pause the voting process ;).

ProgramGenerator is also used for XSPs. And there is certainly more than
one XSP !

The vote won't be stopped : you deserve to be a committer, but my vote
has a warning about tests ;)

Sylvain.

> Cheers
> Gerhard
> 
-- 
Sylvain Wallez
Anyware Technologies - http://www.anyware-tech.com

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org