From cocoon-dev-return-19525-apmail-xml-cocoon-dev-archive=xml.apache.org@xml.apache.org Wed Dec 05 16:51:10 2001 Return-Path: Delivered-To: apmail-xml-cocoon-dev-archive@xml.apache.org Received: (qmail 25184 invoked by uid 500); 5 Dec 2001 16:51:10 -0000 Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: cocoon-dev@xml.apache.org Delivered-To: mailing list cocoon-dev@xml.apache.org Delivered-To: moderator for cocoon-dev@xml.apache.org Received: (qmail 50919 invoked from network); 5 Dec 2001 15:40:32 -0000 X-MimeOLE: Produced By Microsoft Exchange V6.0.4712.0 content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: Cocoon 2.0 Scalability Disappointment Date: Wed, 5 Dec 2001 16:40:26 +0100 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: Cocoon 2.0 Scalability Disappointment Thread-Index: AcF5z+EWDDP3HgnnR0umm+alwNyW8QD0wZEg From: "Tom Klaasen (TeleRelay)" To: X-OriginalArrivalTime: 05 Dec 2001 15:40:55.0526 (UTC) FILETIME=[3A5AE060:01C17DA3] X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N > -----Original Message----- > From: [mailto:nicolaken@supereva.it]=20 > > I think this can be an appropriate timing to start cleaning up the=20 > > logging code. We have to find a policy and stick to it: I=20 > tend to say=20 > > that we should *always* do a isDebugEnabled() or a isInfoEnabled()=20 > > before spitting out Strings. I'm not that sure that such a=20 > policy should=20 > > be enforced for levels of warn and above. >=20 > I totally agree. > This sped up my app quite a bit. > Maybe a static utility method that does the check is nicers=20 > than many ifs. How would you do that? The reason for calling the "isDebugEnabled()" is exactly to avoid all the work involved in concatenating the Strings you're providing as parameter. And this would also be done with static methods... tomK --------------------------------------------------------------------- To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org For additional commands, email: cocoon-dev-help@xml.apache.org