cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From giacomo <giac...@apache.org>
Subject Re: [vote] Finer-grained logging categories (was: Re: Over-Logging)
Date Sun, 30 Dec 2001 17:01:40 GMT
On Sun, 30 Dec 2001, Sylvain Wallez wrote:

> giacomo wrote:
>
> <snip/>
>
>
> >>>>The only drawback is that LogKit complains about categories not
> >>>>explicitly declared in logkit.xconf. Maybe LogKit shouldn't be so picky
> >>>>about that and just act as a configuration front-end to Hierarchy (i.e.
> >>>>remove the m_loggers HashMap).
> >>>>
> >>>This can be fixed (I wrote it) but IIRC it's a debugging (or should
> >>>be) message and thus might be helpfull in that aspect.
> >>>
> >>I would be thankful if you fix it, because it produces a _warning_
> >>message each time a component asks for a logger that's not in the
> >>configuration-defined categories.
> >>
> >
> > Ok, I've reduced from WARN to DEBUG and will commit it soon into C2.
> >
> > Giacomo
> >
>
> Thanks, Giacomo, but I was saying that IMHO, LogKitManager shouldn't
> even care about that. It's role is to configure a Hierarchy (most often
> its top-level categories) and give access to this hierarchy to get
> loggers, but the definition of categories is the responsibility of
> xconf/sitemap writers.

Sure, that's what that debugging messages is helping in finding (maybe
unintentionally) misspelled logging categories attached to components
with the logger attribute which are not define in the logkit.xconf.

> With the hierarchized categories we will now have (many +1 for this
> vote), LogKitManager will issue a great number of debug messages which
> don't give any usefull information.

Give me some example of "not usefull messages" which you think should be
removed. There a only 5 or 6 places where logging messages are issued so
IMO there aren't "a great number of debug messages"

Giacomo

>
> What do you think ?
>
> Sylvain.
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message