cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefano Mazzocchi <stef...@apache.org>
Subject Re: Cleaning up the CVS
Date Fri, 14 Dec 2001 21:02:47 GMT
Marcus Crafter wrote:
> 
> On Wed, Dec 12, 2001 at 03:14:26PM +0100, Stefano Mazzocchi wrote:
> 
> > >         I'm quite keen to learn of a better way to
> > >         ascertain this information and I'm open if you have any suggestions
> > >         about how to improve it ?
> >
> > The code seems to be collecting the maximum number of incoming
> > concurrent requests. It might be useful, I don't know, but for sure it
> > doesn't require synchronization. I mean: adding and subtracting one to a
> > counter is an atomic operation (on ints, it's not on longs, but we don't
> > have that many requests anyway).
> >
> > The non-atomic operation is the comparison with previous maximum. One
> > possible simple solution is to have a sampling thread that reads that
> > value and logs it someplace. It might be useful for profiling
> > information.
> >
> > What do you think?
> 
>         Ok. Sounds good to me.

cool.

>  I'll come up with a diff over the weekend.

Even better.

>         Thanks for your suggestions. Please feel free to offer further critique
>         in the future, it's much appreciated.

Oh, don't worry about that :)

-- 
Stefano Mazzocchi      One must still have chaos in oneself to be
                          able to give birth to a dancing star.
<stefano@apache.org>                             Friedrich Nietzsche
--------------------------------------------------------------------



---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message