cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sylvain Wallez <sylvain.wal...@anyware-tech.com>
Subject Re: [PATCH] Added Resource Monitor in ProgramGeneratorImpl
Date Tue, 11 Dec 2001 10:34:19 GMT


Gerhard Froehlich a écrit :
> 
> Hi,
> as promised I started to implement the Excalibur
> ActiveMonitor in Cocoon to increase our performance.
> 
> I started at the ProgramGeneratorImpl and this Patch
> contains the first draft.
> Every 10sec the ActiveMonitor checks if the Sitemap
> has changed.
> 
> Please review it and give me some feedback!
> 
> Berin: How about a additional URIResource in the
> monitor package?
> 
> Cheers
> Gerhard
> 

Gerhard,

After studying your patch, it appears to be broken :
ProgramGeneratorImpl is TreadSafe and thus a single instance is used for
*all* compiled components. So the lastModified date stored by
propertyChanged() is the date of the last modified program file found by
the ActiveMonitor.

The effect is that the next program requested using load() is
recompiled, but it is very unlikely to be the one that was modified : an
unchanged program is recompiled and the changed one is not recompiled :(

Sylvain.
-- 
Sylvain Wallez
Anyware Technologies - http://www.anyware-tech.com

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message