cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 5501] New: - bug in XSPCookieHelper.getCookie()
Date Wed, 19 Dec 2001 09:06:54 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5501>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5501

bug in XSPCookieHelper.getCookie()

           Summary: bug in XSPCookieHelper.getCookie()
           Product: Cocoon 2
           Version: 2.0alpha CVS
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: general components
        AssignedTo: cocoon-dev@xml.apache.org
        ReportedBy: arnaud.bienvenu@netcourrier.com


If you use, for example, this xsp tag :
<xsp-cookie:getValue name="myCookie"/>

It will fail if there are several cookies set in the client browser for your
site, because XSPCookieHelper.getCookie() will always return the last cookie.

Here is a simple patch to fix this :

Index: src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon2/src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java,v
retrieving revision 1.2.2.9
diff -u -r1.2.2.9 XSPCookieHelper.java
--- src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java	
2001/11/26 15:52:18	1.2.2.9
+++ src/org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java	
2001/12/19 09:04:59
@@ -654,7 +654,10 @@
                     currentCookie = cookies[count];
 
                     if (currentCookie.getName().equals(cookieName))
+                    {
                         matchFound = true;
+                        break;
+                    }
                     count++;
                 }
             }

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message