cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gerhard Froehlich" <g-froehl...@gmx.de>
Subject RE: [PATCH] MRUMemoryStore and fellows fixes
Date Wed, 21 Nov 2001 11:20:00 GMT
>> >I'm currently incorporating your patches (Startable interface).
>> >For this I have to change some component handling.
>> >I will finish this in 1h (aprox) and then you can add
>> >your filtering easily.
>> 
>> Was it wrong, the way I implemented it?
>> 
>The implementation of the MRUMemoryStore and the FileysystemQueueImpl
>was not correct since a long time. They looked up some components
>but never released them.

Yes that's true, my fault :(

>The second thing is: As far as I know, you don't have to call
>the start() or stop() method of a Startable component itself.
>It's done by the ComponentManager.

Good to know...

>> >> 
>> >> >thanks for your patch! But - sorry for this pain -
>> >> 
>> >> autsch ;)
>> >> 
>> >> >I think we should not change existing interfaces
>> >> >like the Store interface.
>> >> 
>> >> I know you would say, that. For my defence I didn't
>> >> wanted to change the FilesystemStore. I did it once
>> >> and got - well - in trouble.
>> >> 
>> >> >The MRUMemoryStore calls the keys() method
>> >> >of the FilesystemStore. The fsstore returns
>> >> >all keys, but only those contained in a special
>> >> >directory are of interest. 
>> >> 
>> >> That would be nice.
>> >> 
>> >> >What do you think of filtering the keys() 
>> >> >delivered by the fsstore in the MRUMemoryStore?
>> >> >I know this is slow but would allow us to keep
>> >> >the interface.
>> >> 
>> >> Yes that would be a solution. The next Problem
>> >> are this two Enumerations. I did a awful hack
>> >> to megre them together. Maybe you know a better
>> >> solution.
>> >> 
>> >> >In addition the keys() method of the fsstore
>> >> >is wrong as it doesn't go into directories.
>> >> >I will fix this asap.
>> >> 
>> >> Ok then I can implement the filter.
>> >> 
>> >> Cheers
>> >> Gerhard
>> >> 
>> >> >
>> >> >Carsten
>> >> >
>> >> >Gerhard Froehlich wrote:
>> >> >> 
>> >> >> 
>> >> >> Hi,
>> >> >> as promised this patch contains serveral fixes
>> >> >> in the store implementation:
>> >> >> 
>> >> >> MRUMemoryStore:
>> >> >> - added Disposable interface and implemented 
>> >> >> the initialize() and dispose() method to init-
>> >> >> ialize/dispose the StoreJanitor and the FilesystemQueue
>> >> >> thread.
>> >> >> - completed the methods containsKey() and keys()
>> >> >> (I needed to extend the Store interface and the
>> >> >> FilesystemStore too)
>> >> >> 
>> >> >> StoreJanitor:
>> >> >> - added the Startable interface and implemented
>> >> >> start() and stop() to start/stop the checker
>> >> >> thread
>> >> >> 
>> >> >> FileSystemQueue:
>> >> >> - added the Startable interface and implemented
>> >> >> start() and stop() to start/stop the writer
>> >> >> thread
>> >> >> 
>> >> >> Cheers
>> >> >> Gerhard
>> >> >> --------------------------------------------
>> >> >> black holes are when GOD is dividing by zero
>> >> >> 23 49 43 51 3A 20 31 32 33 35 33 34 38 31 31
>> >> >> --------------------------------------------
>> >> >
>> >> >---------------------------------------------------------------------
>> >> >To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
>> >> >For additional commands, email: cocoon-dev-help@xml.apache.org
>> >> >
>> >> >
>> >> 
>> >> 
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
>> >> For additional commands, email: cocoon-dev-help@xml.apache.org
>> >> 
>> >
>> >---------------------------------------------------------------------
>> >To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
>> >For additional commands, email: cocoon-dev-help@xml.apache.org
>> >
>> >
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
>> For additional commands, email: cocoon-dev-help@xml.apache.org
>> 
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
>For additional commands, email: cocoon-dev-help@xml.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message