cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Bertram" <bert...@n-bis.de>
Subject RE: new: [C2.1][PATCH] DatabaseReader
Date Mon, 05 Nov 2001 09:46:20 GMT
Hi Berin,

here are the new DatabaseReader PATCH

The new parameters are:
content-lookup-type
expires-lookup-type

i had also include a new parameter resource as replacement for image
I see this reder not only for images, so it could confused the user who
dosn't read the source.
The old one works also but in the documentation (javadocs) it is marked as
deprecated
I hope you are confirmed with this

Klaus


> > -----Original Message-----
> > From: Berin Loritsch [mailto:bloritsch@apache.org]
> > Sent: Friday, November 02, 2001 6:38 PM
> > To: cocoon-dev@xml.apache.org
> > Subject: Re: second: [C2.1][PATCH] DatabaseReader
> >
> >
> > Klaus Bertram wrote:
> > >
> > > -----Original Message-----
> > > From: Klaus Bertram [mailto:bertram@n-bis.de]
> > > Sent: Wednesday, October 24, 2001 8:27 PM
> > > To: Cocoon dev
> > > Subject: [C2.1][PATCH] DatabaseReader
> > >
> > > Hi all,
> > >
> > > here are a patch for the DatabaseReader
> > > changes:
> > > The optional params for expires and content-type are now for
> > database column
> > > names
> > > if they are not set the sidemap params used
> >
> >
> > The biggest problem with moving these to database columns is that
> > now you made the decision to include these params a DB administrator
> > issue.  Is it useful to return a different type based on a DB attribute?
> > Sure it is.  But not at the exclusion of explicitly setting it in the
> > Sitemap!  In cases where you are only returning 1 type of content or
> > the time-out setting is purely a site administrator's concern, we need
> > to keep the abilities it has now.
> >
> > Your changes would break my site.  We need to remain backwards
> compatible.
> > If you introduced a couple new parameters like "mime-lookup-type" and
> > "expires-type" that were enumerated ("db" and "value" with "value" the
> > default), then you would be able to repurpose the parameters in a
> > backwards compatible way.
> >
> > > so that the DatabaseReader is a litle bit more transparent
> > >
> > > there was also a term inside
> > >         Timestamp modified = set.getTimestamp(lastModified,null);
> > > this don't work with the mySQL driver i had chaned it to
> > >         Timestamp modified = set.getTimestamp(lastModified);
> > > so please try it with other database drivers also
> >
> > Keep up the good work.  Please make the adjustments above.
> >
> > >
> > > Have fun Klaus
> > >
> > >
> > ------------------------------------------------------------------
> > ------------------------------------------------------------------
> > >                           Name: DatabaseReader.diff
> > >    DatabaseReader.diff    Type: unspecified type
> > (application/octet-stream)
> > >                       Encoding: quoted-printable
> > >
> > >
> > ------------------------------------------------------------------
> > ------------------------------------------------------------------
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
> >
> > --
> >
> > "Those who would trade liberty for
> >  temporary security deserve neither"
> >                 - Benjamin Franklin
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org

Mime
View raw message