cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler" <cziege...@sundn.de>
Subject AW: Configuration of SourceFactories
Date Tue, 16 Oct 2001 15:43:09 GMT
> Gianugo Rabellino wrote:
> 
> > > > > how about making SourceFactories configurable?
> > > > The main reason is that there was no need for it until now...
> > > > So you're welcome to send a patch for this to extend the
> > > > SourceHandlerImpl with this feature :-)
> > >
> > > OK, it was a quick patch so attached is my working version. It
> should be
> > > a pretty straightforward addition, but please review it carefully :)
> > >
> > Thanks for this! It's applied - please check as I slightly changed
> > the code (no instance variable is used to hold the configuration,
> > and I corrected a bug of lifecycle-initialization of the factories
> > which existed before your patch).
> 
> Ouch! The patch doesn't work if used this way: it 's now written exactly
> as my first version was, but I changred it because I saw that it
> impacted the source twice. If you choose this method (which is perfectly
> fine to me) you have also to patch at line 161 where you are calling:
> 
>     this.init(factory)
> 
> it should be something like
> 
>     this.init(factory, null)
> 
> since there is no Configuration object to pass on. As of now, Cocoon
> doesn't even compile :/
> 
Argh, yes thanks - don't know why my compiletest succeeded, but anyway
I just checked in a fix.

> Thanks a lot for being so quick. Would it be the case to add this patch
> to the 2.0 branch too? I understand that it touches the core API, yet it
> would be impossible to use a Configurable SourceFactory without it.
> 
Yes, right before the release candidate 2 we will have a cycle on which 
features we should port back from the head to the 2.0 branch. 

I'm very confident that this is one which will go into 2.0.

Carsten

> Ciao,
> 
> --
> Gianugo
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message