cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Torsten Curdt" <tcu...@dff.st>
Subject RE: [patch] improved esql.xsl
Date Tue, 02 Oct 2001 12:27:54 GMT
> Torsten,
> 
> I looked at your patch, and although I'm not very familiar with the
> esql logicsheet, your changes seem to be in the right direction. I
> would give a +1 to them (note I'm not a committer ;-).

Thanks, Ovidiu.

I'm not sure if I want to bug Donald off the list.
(I did so before ;)

Is there really no other committer familiar enough to
say if this patch is ok!?

> One improvement you can probably make is to pool the EsqlConnection
> objects, so you can obtain even better performance. This may be tricky
> to do though, as each connection might be connected using a different
> user account. These are only some thoughts, it doesn't mean you have
> to implement them now.

The SQLConnections are already pooled. The EsqlConnections were introduced
by Donald to have more convenient access to all related variables.

> Ovidiu
> 
> PS: BTW, anybody knows what happened to Donald?

He must be alright. I meet him on the resin list ;)

> 
> On Mon, 01 Oct 2001 10:58:31 +0200, Torsten Curdt <tcurdt@dff.st> wrote:
> 
> > could someone *PLEASE* have a look?
> > Thanks
> > --
> > Torsten
> > 
> > > It has been pretty quite around Donald (Donald, are you still out
> > > there ;) Christian, maybe you could have a look?
> > > 
> > > We have had no problem within any old esql page so far.
> > > But we can only test it with one database (sybase ASA).
> > > 
> > > Thanks
> > > --
> > > Torsten
> > > 
> > > > -----Original Message-----
> > > > From: Carsten Ziegeler [mailto:cziegeler@sundn.de]
> > > > Sent: Friday, September 28, 2001 8:12 AM
> > > > To: Cocoon-Dev@Xml. Apache. Org
> > > > Subject: AW: [patch] improved esql.xsl
> > > > 
> > > > 
> > > > Hi Team,
> > > > 
> > > > could someone with more knowledge of eqsl than me
> > > > look at this patch, please?
> > > > 
> > > > Carsten
> > > > 
> > > > > -----Ursprungliche Nachricht-----
> > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > Gesendet: Donnerstag, 27. September 2001 11:39
> > > > > An: Carsten Ziegeler
> > > > > Cc: cocoon-dev@xml.apache.org
> > > > > Betreff: Re: AW: [patch] improved esql.xsl
> > > > > 
> > > > > 
> > > > > recreated it from the current CVS so it should be fine.
> > > > > Thanks
> > > > > --
> > > > > Torsten
> > > > > 
> > > > > > Hi Torsten,
> > > > > >
> > > > > > it looks like your patch is still not applied.
> > > > > > Could you please test if it works and then
> > > > > > resend the patch, so we can apply it?
> > > > > >
> > > > > > Carsten
> > > > > >
> > > > > > > -----Ursprungliche Nachricht-----
> > > > > > > Von: Torsten Curdt [mailto:tcurdt@dff.st]
> > > > > > > Gesendet: Freitag, 21. September 2001 14:08
> > > > > > > An: cocoon-dev@xml.apache.org
> > > > > > > Betreff: RE: [patch] improved esql.xsl
> > > > > > >
> > > > > > >
> > > > > > > Are there any objections on this one?
> > > > > > > --
> > > > > > > Torsten
> > > > > > >
> > > > > > > > I straightened out the latest esql.xsl logicsheet
> > > > > > > >
> > > > > > > >   - removed the inner classes (created real ones)
> > > > > > > >   - moved redundant code into a helper class
> > > > > > > >   - added support for jdbc ResultSet positioning
> > > > > > > >     (now we can do paging not only for MySQL and PostgreSQL
> > > > > > > >      and it's quite easy to add more)
> > > > > > > >   - added a <esql:previous-results> as counterpart
of
> > > > > > > <esql:more-results>
> > > > > > > >
> > > > > > > > Everything else should be same as before.
> > > > > > > >
> > > > > > > > I could not test this thoroughly but it would be
> > > > > > > > great if someone could apply this to the current head
branch.
> > > > > > > >
> > > > > > > > Thanks
> > > > > > > > --
> > > > > > > > Torsten
> > > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> > 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message