Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cocoon-dev@xml.apache.org
From: "John Morrison" <john.r.morrison@ntlworld.com>
To: <cocoon-dev@xml.apache.org>
Subject: RE: [C2 patch] appending to cocoon.log
Date: Mon, 20 Aug 2001 21:04:15 +0100
Message-ID: <NLEGIGLCGEEOHJGJBGPOAEAOCEAA.john.r.morrison@ntlworld.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Importance: Normal
In-Reply-To: <NEBBKBNHBMFHDJPKGCOBMEMKCOAA.vgritsenko@hns.com>


> -----Original Message-----
> From: Vadim Gritsenko [mailto:vgritsenko@hns.com]
> Sent: Monday, 20 August 2001 8:07 pm
> To: cocoon-dev@xml.apache.org
> Subject: RE: [C2 patch] appending to cocoon.log
>
>
> > -----Original Message-----
> > From: Marcus Crafter [mailto:crafterm@fztig938.bank.dresdner.net]
> > Sent: Monday, August 20, 2001 2:20 PM
> > To: cocoon-dev@xml.apache.org
> > Subject: RE: [C2 patch] appending to cocoon.log
> >
> >
> > Hi Vadim,
> >
> > On Sat, 18 Aug 2001, Vadim Gritsenko wrote:
> >
> > > Hm. Interesting question. :)
> > > I just modified this so it's compatible with other boolean settings.
> > > "True" might be overkill - next thing you know people will
> ask about internationalization ;)
> >
> > 	*nod* Point taken.
> >
> > 	I just noticed that log-format and show-time use
> equalsIgnoreCase() so
> > 	we already have a discrepancy there. :-(
> >
> > 	Just being picky herer, but the other thing is that
> (general with most
> > 	of the options):
> >
> > 		true equates to true, as expected
> > 		false equates to false, as expected
> >
> > 		with the current implementation,
> >
> > 		False also equates to false, as most would probably expect
> > 		FALSE also equates to false, as most would probably expect
> >
> > 		but
> >
> > 		True equates to false, not what most would expect
> > 		TRUE equates to false, not what most would expect
> >
> > 	This could cause some configuration woes for the unwary.
>
> Point taken :)
>
> >
> > 	Another general question here, the current implementation appends to
> > 	log files if the init parameter is not set (ie. if
> > 	getInitParameter("log-append") returns null) - do we want this to be
> > 	the case ?
>
> Don't know.

My doing - I spent a couple of days looking for a 'bug' that didn't exist
and all because I hadn't set something in the web.xml file.

When I (eventually :) get ssh access through the firewall at work, I'll be
quite happy to go through looking for these little gems and adding the log
message - if people want...?

While I don't mind picking up the defaults it is useful (I think) to have
the defaults logged.  This means that when folks send us their log we can
see their settings...?  Huh, maybe we ought to log _all_ settings whether
specified or default?

> Vadim
>
> >
> > 	Cheers,
> >
> > 	Marcus
> >
> > --
> >         .....
> >      ,,$$$$$$$$$,      Marcus Crafter
> >     ;$'      '$$$$:    Computer Systems Engineer
> >     $:         $$$$:   Open Software Associates GmbH
> >      $       o_)$$$:   82-84 Mainzer Landstrasse
> >      ;$,    _/\ &&:'   60327 Frankfurt Germany
> >        '     /( &&&
> >            \_&&&&'     Email : Marcus.Crafter@osa.de
> >           &&&&.        Business Hours : +49 69 9757 200
> >     &&&&&&&:
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> > For additional commands, email: cocoon-dev-help@xml.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org