cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vadim Gritsenko" <vgritse...@hns.com>
Subject RE: [C2]: Performance and logging
Date Tue, 07 Aug 2001 12:59:04 GMT
> -----Original Message-----
> From: Carsten Ziegeler [mailto:cziegeler@sundn.de]
> Sent: Tuesday, August 07, 2001 6:36 AM
> To: Cocoon-Dev@Xml. Apache. Org
> Subject: [C2]: Performance and logging
> 
> 
> Hi,
> 
> I know that we had this discussion some time ago, with no real solution,
> so I thought: why not start it again?
> 
> Looking at the way logging is performed in cocoon 2, I think this is
> not very fast. Here an example:
> 
> <CODE>
>   getLogger().debug("Creating new Templates in " + this + " for " +
> this.inputSource.getSystemId());
> </CODE>
> 
> Even if the priority debug is disabled, the method getLogger() (from
> AbstractLoggable) is called returning the logger,

IIRC, argument here was that getLogger() method is final and should
be inlined by hotspot/JIT engine...


> the expensive string concatenation is performed and the debug() method
> of the logger is called. And these steps are done for every debug message!
> 

Same thing here: if method is inlined, first is...enabled() check should occur.
I'm not sure however that this occurs in reality.

Carssten,
Did you try to coment out all debug messages to check the difference in
processing time?


Vadim

> We should change two things here:
> a) Replace the getLogger() call with the use of an instance variable logger.
>    This requires to make an own AbstractLoggable class which offers the
> logger as an instance
>    variable and not via a method.
> b) Before logging testing the priority.
> 
> So the example above should read:
> 
> <CODE>
>   if (this.logger.isDebugEnabled() == true) {
>     this.logger.debug("Creating new Templates in " + this + " for " +
> this.inputSource.getSystemId());
>   }
> </CODE>
> 
> Comments? Ideas? Suggestions? Volunteers?
> 
> 
> Carsten
> 
> Open Source Group                        sunShine - b:Integrated
> ================================================================
> Carsten Ziegeler, S&N AG, Klingenderstrasse 5, D-33100 Paderborn
> www.sundn.de                          mailto: cziegeler@sundn.de
> ================================================================
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message