cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Newland" <chris.newl...@emorphia.com>
Subject Patch for XSPCookieHelper.java
Date Fri, 17 Aug 2001 13:02:02 GMT
Hi All,

I think there is a bug in
org/apache/cocoon/components/language/markup/xsp/XSPCookieHelper.java

Setting false for the security setting on a cookie resulted in the security
being set to true and so the cookie would not be uploaded using a non secure
protocol.

With this patch, it will now only set security to true if the string "true"
is passed as parameter.

Hope this helps,

Chris

PS. I have created a new XSP cookie example that splits the cookie set and
upload into 2 different pages to make it a little clearer. Would you like me
to submit this?



Index: XSPCookieHelper.java
===================================================================
RCS file:
/home/cvspublic/xml-cocoon2/src/org/apache/cocoon/components/language/markup
/xsp/XSPCookieHelper.java,v
retrieving revision 1.2.2.3
diff -u -r1.2.2.3 XSPCookieHelper.java
--- XSPCookieHelper.java	2001/08/16 13:39:17	1.2.2.3
+++ XSPCookieHelper.java	2001/08/17 12:37:08
@@ -99,8 +99,10 @@
             if ((path.trim()).length() > 0)
                 cookieToSet.setPath("/");

-            if (secure == "true" || secure == "false")
+            if (secure == "true")
                 cookieToSet.setSecure(true);
+	    else
+		cookieToSet.setSecure(false);

             cookieToSet.setVersion(version);
             response.addCookie(cookieToSet);





--
Chris Newland
Software Research Engineer

Emorphia Ltd
Registered in England.  4133002
Mill House, Station Approach, Harlow Mill, Harlow, Essex, CM20 2EL, UK

Email: chris.newland@emorphia.com
Tel: +44 (0)1279 450100
Fax: +44 (0)1279 450102

Check out FIPA-OS at http://fipa-os.sourceforge.net/

This message may contain information proprietary to Emorphia so any
unauthorised disclosure, copying or distribution of its contents is strictly
prohibited.



---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message