cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler" <cziege...@sundn.de>
Subject AW: [C2B2] Big Bug in sub-sitemap handling (?)
Date Sun, 29 Jul 2001 11:17:05 GMT
Ok, I was wrong...

The bug was in the SitemapComponentSelector which didn't call the
parent selector when a component was released. I fixed this, but
I am not sure if this is a correct solution:
The component is released in the selector itself AND in the parent
selector as we can't detect which selector was used to lookup the
component. Is this ok, Berin?

But I still think that my first guess is correct, too. The invoke()
method with the pipeline objects is of course only called for internal
pipelines. So my guess is still that the releasing scheme doesn't
work for internal pipelines in subsitemaps (when called from the
top sitemap). Any experience here?

Now I can go to the beach again...

Carsten

> Carsten Ziegeler wrote:
>
> Hi,
>
> as I am on vacation right now, I can't test or even build c2. Looking
> through the generated code
> for subsitemaps for about 5 minutes, I think it is wrong:
>
> When a subsitemap is entered the invoke() method of the sitemap manager is
> called, this
> method gets among some other paramters the EventPipeline and the
> StreamPipeline. These are
> passed to the subsitemap and used there to initialize components which
> belong to a
> ComponentManager of the subsitemap. After the event is processed, the root
> sitemap
> releases the objects with the ComponentManager of the root sitemap and not
> of the subsitemap,
> so they cannot be released.
> This actually is only my guess. Perhaps I am wrong. (But I hope not).
>
> So, could someone test this by simply changing the sitemap.xsl,
> so that the
> invoke() method
> of the sitemap manager is called without passing the event and stream
> pipeline, please? The
> manager has the invoke method with both signatures.
>
> If I get some free time in my vacation I could perhaps look at the result
> tomorrow evening.
> But don't expect any reply from me for the next days...Sorry!
>
> Greetings from the sun,
>
> Carsten
>
> >>>>>>>>>>>
> Matthew Langham wrote:
>
> After comparing the logs I can now add a little to that:
>
> When the pipeline is in the subsitemap components such as the
> TraxTransformer are _retrieved_ from the pool - but they are not returned!
> This is the case if the pipeline is in the "normal" sitemap.
>
> Matthew
>
> --
> Open Source Group               sunShine - Lighting up e:Business
> =================================================================
> Matthew Langham, S&N AG, Klingenderstrasse 5, D-33100 Paderborn
> Tel: +49-5251-1581-30   [mlangham@sundn.de - http://www.sundn.de]
> =================================================================
>
>
> -----Urspr√ľngliche Nachricht-----
> Von: Matthew Langham [mailto:mlangham@sundn.de]
> Gesendet: Samstag, 28. Juli 2001 15:26
> An: cocoon-dev@xml.apache.org
> Betreff: [C2B2] Big Bug in sub-sitemap handling (?)
>
>
> I think I have found a bug in the sub-sitemap handling. Unfortunately (for
> me anyway) Carsten is on holiday - so maybe someone else has an idea..
>
> I have tested memory consumption using Jprobe. From the results it seems
> that pipelines in sub-sitemaps are not released from memory. This
> means that
> after a request has been processed all the components (!) are
> still held in
> memory. This means that repetitive requests cause the memory to fill up.
>
> I tested the same pipeline in the normal sitemap and everything was fine.
>
> Can someone confirm this - and maybe offer a solution (apart from
> not having
> sub-sitemaps)?
>
> Matthew
>
> --
> Open Source Group               sunShine - Lighting up e:Business
> =================================================================
> Matthew Langham, S&N AG, Klingenderstrasse 5, D-33100 Paderborn
> Tel: +49-5251-1581-30   [mlangham@sundn.de - http://www.sundn.de]
> =================================================================
>
> <<<<<<<<<<<<<<<<<<<<<<<<
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message