Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cocoon-dev@xml.apache.org
Message-ID: <001601c0eb93$ff44e940$01c8c8c3@RAEL>
From: "Carsten Ziegeler" <c.ziegeler@online.de>
To: <cocoon-dev@xml.apache.org>
Subject: RE: [C2] Patch: ArrayIndexOutOfBoundsException after other exceptions
Date: Sat, 2 Jun 2001 20:38:20 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: 7bit

Hi Jeff,

sorry, but I don't have enough knowledge of XSP and the generator
to help here.
Perhaps someone else of the comiiters could look at this?

Carsten

> Carsten,
>
> Thanks.  Clearing the stack after an exception didn't cause any problems
in
> my tests, but I agree there are probably cases when it would.
>
> I have one other related suggestion.  Currently if an XSP page generates
an
> exception other than IOException, SAXException, or ProcessingException, it
> is caught but not re-thrown.  So, it doesn't end up being reported, and
all
> the user sees is a incomplete (although valid if the event stack clearing
> worked) XML page.  It would be nice if any exception was reported through
> the Cocoon XML page.  The workaround is to put a try/catch in the XSP page
> and re-throw any exceptions as SAXExceptions, but I think that's more work
> than it's worth (You have to do that anyway if you use any classes that
> throw explict exceptions, but that's a different topic.)
>
> In ServerPagesGenerator.generate(), if the following line is added:
>
>     } catch (Exception e){
>         getLogger().error("Exception in ServerPagesGenerator.generate()",
> e);
> >>>     throw new ProcessingException("Exception in
> ServerPagesGenerator.generate()", e);
>     } finally {
>
> Any other exception from the XSP page will be re-thrown and the Cocoon
error
> page will be displayed.  It also allows the XSP developer to catch the
> exception and just return from the page to keep the error page from being
> displayed and the normal event stack cleanup to occur.
>
> Let me know what you think.
>
> -------------------------
> Jeff Skaistis
> jeff.skaistis@alistia.com


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org