cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Berin Loritsch <blorit...@apache.org>
Subject Re: javax.sql.DataSource
Date Tue, 19 Jun 2001 20:27:50 GMT

> > > 2. esql.xsl. In case when a connection is obtained from DataSource one
> > > should not invoke setAutoCommit() method. Otherwise SQLException will be
> > > thrown. Looking at esql.xsl, I've found that you catch any exceptions thrown
> > > by this method but you rethrow RuntimeException which is incorrect. I don't
> > > think you should throw any exception in this exception handler. See esql.xsl
> > > line 362.

would it be propper of us to only setAutoCommit if we are manually declaring our
connection?  I would think so--esp. since Avalon's DataSourceComponent manages
the AutoCommit correctly.

> I have not forgotten about Cocoon 1 version of esql.xsl.  I am trying to get a
> fresh copy of it from CVS, but my client is chugging for a long time.  Once I
> get it, I will commit the same change in Cocoon 1.

This part is done.
Mime
View raw message