cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Berin Loritsch <blorit...@apache.org>
Subject Re: javax.sql.DataSource
Date Tue, 19 Jun 2001 20:08:01 GMT
Berin Loritsch wrote:
> 
> kesha wrote:
> >
> > Hi guys,
> >
> > I've tried to deploy cocoon into WL 6.0 server and use DataSource as a jdbc
> > Connection factory. Doing that, I've found a couple of bugs. Could anybody
> > to commit the following changes into CVS:
> >
> > 1. cocoon.roles, role name
> > "org.apache.avalon.excalibur.datasource.DataSourceComponentSelector". The
> > hint for j2ee points to the wrong class name. Insteed of
> > "org.apache.avalon.excalibur.datasource.J2eeDataSource" it points to
> > "org.apache.excalibur.datasource.J2eeDataSource".
> > 2. esql.xsl. In case when a connection is obtained from DataSource one
> > should not invoke setAutoCommit() method. Otherwise SQLException will be
> > thrown. Looking at esql.xsl, I've found that you catch any exceptions thrown
> > by this method but you rethrow RuntimeException which is incorrect. I don't
> > think you should throw any exception in this exception handler. See esql.xsl
> > line 362.
> 
> I'm glad that works for you!
> I have applied your fixes, and am committing them now. (esql.xsl is a bit tricky
> in that it has to be updated in three repositories....)

This message is for Donald Ball:

I have not forgotten about Cocoon 1 version of esql.xsl.  I am trying to get a
fresh copy of it from CVS, but my client is chugging for a long time.  Once I
get it, I will commit the same change in Cocoon 1.


Reguarding the above statement # 2:

would it be propper of us to only setAutoCommit if we are manually declaring our
connection?  I would think so--esp. since Avalon's DataSourceComponent manages
the AutoCommit correctly.
Mime
View raw message