Return-Path: Delivered-To: apmail-xml-cocoon-dev-archive@xml.apache.org Received: (qmail 16231 invoked by uid 500); 4 May 2001 22:13:56 -0000 Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: cocoon-dev@xml.apache.org Delivered-To: mailing list cocoon-dev@xml.apache.org Received: (qmail 15215 invoked from network); 4 May 2001 22:13:31 -0000 Date: Fri, 4 May 2001 23:37:21 +0200 (CEST) From: giacomo X-X-Sender: To: Subject: Re: cvs commit: xml-cocoon/src/org/apache/cocoon/reading DatabaseReader.java In-Reply-To: <20010504194313.67342.qmail@apache.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N On 4 May 2001 bloritsch@apache.org wrote: > bloritsch 01/05/04 12:43:12 > > Modified: src/org/apache/cocoon/reading Tag: xml-cocoon2 > DatabaseReader.java > Log: > Made DatabaseReader cacheable. It's wicked fast. Great improvement. > > Revision Changes Path > No revision > > > No revision > > > 1.1.2.16 +115 -47 xml-cocoon/src/org/apache/cocoon/reading/Attic/DatabaseReader.java > > + /** > + * Generate the validity object. > + * > + * @return The generated validity object or null if the > + * component is currently not cacheable. > + */ > + public CacheValidity generateValidity() { > + if (this.lastModified > 0) { > + return new TimeStampCacheValidity(this.lastModified); > + } else { > + return new NOPCacheValidity(); > + } > + } I'm not quite sure but doesn't this mean that if there is no lastModified value it will never be invalidated because of the NOPCacheValidity? Giacomo --------------------------------------------------------------------- To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org For additional commands, email: cocoon-dev-help@xml.apache.org