Return-Path: 
 <cocoon-dev-return-12723-apmail-xml-cocoon-dev-archive=xml.apache.org@xml.apache.org>
Delivered-To: apmail-xml-cocoon-dev-archive@xml.apache.org
Received: (qmail 9128 invoked by uid 500); 22 Apr 2001 08:26:29 -0000
Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:cocoon-dev-help@xml.apache.org>
list-unsubscribe: <mailto:cocoon-dev-unsubscribe@xml.apache.org>
list-post: <mailto:cocoon-dev@xml.apache.org>
Reply-To: cocoon-dev@xml.apache.org
Delivered-To: mailing list cocoon-dev@xml.apache.org
Received: (qmail 8980 invoked from network); 22 Apr 2001 08:26:28 -0000
Message-Id: <3.0.6.32.20010422183006.00eb21e0@mail.alphalink.com.au>
X-Sender: gdonald@mail.alphalink.com.au
X-Mailer: QUALCOMM Windows Eudora Light Version 3.0.6 (32)
Date: Sun, 22 Apr 2001 18:30:06 +1000
To: cocoon-dev@xml.apache.org
From: Peter Donald <donaldp@apache.org>
Subject: Re: cvs commit:
  xml-cocoon/src/org/apache/cocoon/components/language/markup/xsp/java
  xsp.xsl
In-Reply-To: <20010422081225.83429.qmail@apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N

At 08:12  22/4/01 -0000, giacomo@apache.org wrote:
>giacomo     01/04/22 01:12:25
>  Index: xsp.xsl
>  ===================================================================
>  RCS file:
/home/cvs/xml-cocoon/src/org/apache/cocoon/components/language/markup/xsp/ja
va/Attic/xsp.xsl,v
>  retrieving revision 1.1.2.26
>  retrieving revision 1.1.2.27
>  diff -u -r1.1.2.26 -r1.1.2.27
>  --- xsp.xsl	2001/04/12 16:57:03	1.1.2.26
>  +++ xsp.xsl	2001/04/22 08:12:25	1.1.2.27
>  @@ -11,7 +11,7 @@
>   
>   <!--
>    * @author <a href="mailto:ricardo@apache.org>Ricardo Rocha</a>
>  - * @version CVS $Revision: 1.1.2.26 $ $Date: 2001/04/12 16:57:03 $
>  + * @version CVS $Revision: 1.1.2.27 $ $Date: 2001/04/22 08:12:25 $
>   -->
>   
>   <!-- XSP Core logicsheet for the Java language -->
>  @@ -43,6 +43,7 @@
>       import org.xml.sax.helpers.*;
>   
>       import org.apache.avalon.*;
>  +    import org.apache.avalon.component.*;

I would highly recomend that unglobbed versions of imports are used. ie

import org.apache.avalon.component.ComponentManager;

This makes it much easier for new users to identify where a particular
class comes from (otherwise they would have to search through all the
globbed import packages) and it also makes it easy when to refactor using
scripts ;)

Cheers,

Pete

*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof."                   |
|              - John Kenneth Galbraith               |
*-----------------------------------------------------*


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org