cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <giac...@apache.org>
Subject Re: AW: cvs commit: xml-cocoon/webapp/WEB-INF web.xml
Date Tue, 03 Apr 2001 11:00:13 GMT
Quoting Carsten Ziegeler <cziegeler@sundn.de>:

> > Giacomo Pati wrote:
> > Quoting cziegeler@apache.org:
> > 
> > >   +        String value = conf.getInitParameter("allow-reload");
> > >   +        if (value == null || value.equals("yes") == true) {
> > 
> > Why are you writing the last statement that way? Would it be better to
> > write it
> > like
> > 
> >      if ("yes".equals(value) == true) {
> > 
> > That way you don't need the additional test against null.
> > 
> Yes, you're right,
> 
> I accidentally used our company coding style. 
> Sorry for that, I will change it as soon as my cvs works again.

This has nothing to do with coding style. It's only simpler code IMHO.

Giacomo

> 
> Carsten
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org
> 
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message