cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Scott_B...@lotus.com
Subject Re: [PATCH] Re: [C2][Xalan2] Xalan2J problems under heavy load using Apache JMeter
Date Fri, 16 Mar 2001 15:00:07 GMT

> If would be great if you could detect such misuse in the Xalan side and
> throw us an Exception on the face before the error is deeply hidden.
> Like having a flag set when the declaration is seen, and throwing an
> error if a second declaration comes...

Yes, I absolutely agree, and will put in a check for this today.

> BTW is the error about not closing the ">" of the "<!DOCTYPE" at
> serialization time xalan related?

http://nagoya.betaversion.org/bugzilla/show_bug.cgi?id=773 was fixed a
couple of weeks ago.

-scott




                                                                                         
                         
                    Santiago Gala                                                        
                         
                    <sgala@hisite        To:     cocoon-dev@xml.apache.org            
                            
                    ch.com>              cc:     (bcc: Scott Boag/CAM/Lotus)          
                            
                                         Subject:     Re: [PATCH] Re: [C2][Xalan2] Xalan2J
problems under heavy    
                    03/16/01             load using  Apache JMeter                       
                         
                    06:07 AM                                                             
                         
                    Please                                                               
                         
                    respond to                                                           
                         
                    cocoon-dev                                                           
                         
                                                                                         
                         
                                                                                         
                         




Scott_Boag@lotus.com wrote:

> Santiago, I'm not sure how those patches relate to the threading problems
> occurring at the Xalan level (but I think probably caused by something at
> the Cocoon level, or perhaps some combo thereof).  Can you explain more?
>

My patch included the nulling of a contentHandle and a lexicalHandler
for the Serializer. The chain of calls to super.recycle() was broken,
and thus some of the parent classes were not properly recycled.

My guess was that the same could happen with other inheritance chains,
but I don't know enough of Cocoon architecture. As I fixed the
propagation of super.recycle() for an Abstract class, all classes
inheriting from it would be affected (how many?)

What you said about a transformer not being properly recycled has the
same structural pattern that the error I found. And don't forget that
the same programmers make consistenly the same errors in different places
:)

Also, I found synchronization problems in the JdbcConnectionPool. I have
not looked at the generic pools, but, again,...


> What I've now proved is that a Transformer held by the TransformerHandler
> held by the TraxTransformer is entered twice, which shouldn't happen in
any
> case according to my reading of the Cocoon code.  That's really all I've
> proved so far... I've been on and off this bug over the last few days.  I
> know why the exception is occuring and the cause from the Xalan
> perspective, but haven't been able to track down what is going on up the
> stack so far.
>

If would be great if you could detect such misuse in the Xalan side and
throw us an Exception on the face before the error is deeply hidden.
Like having a flag set when the declaration is seen, and throwing an
error if a second declaration comes...

BTW is the error about not closing the ">" of the "<!DOCTYPE" at
serialization time xalan related?


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org






---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message