cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santiago Gala <sg...@hisitech.com>
Subject Re: [PATCH] Re: [C2][Xalan2] Xalan2J problems under heavy load using Apache JMeter
Date Fri, 16 Mar 2001 00:10:10 GMT
Berin Loritsch wrote:

> Santiago Gala wrote:
> 
>> Scott_Boag@lotus.com wrote:
>> 
>> 
>>> Thanks Davanum.  I actually reproduced what I believe is the equivalent to
>>> this bug last night.  So I'll keep working with that test, and then try
>>> your add-department2 to verify that it is fixed.
>>> 
>>> -scott
>>> 
>>> 
>> 
>> I have searched a little bit two bugs. The one commented here (maybe),
>> and the problem with <!DOCTYPE not closing ">".
>> 
>> I found two problems in XMLSerializer:
>> 
>> - The serializer "wap", for WML and the XMLSerializer used in voiceML
>> are in the same pool. So, funny things happen. If you hit first the
>> hello.vml page, the .wml page works (without doctype). If it is the
>> other way round, both fail because the WML DOCTYPE is not properly
>> closed. I have no fix for this one, other than having different pools in
>> Avalon to manage the serializers that have different properties.

What about this one? Anybody knows?

>> 
>> - Following the chain of inheritance, I found that XMLSerializer fails
>> to propagate .recycle() up. There is a missing class in the hierarchy.
>> There is a intermediate class that does not implement Recyclable.
>> 
>> I used the following patch to ensure super is called. I'm not sure about
>> reinitializing the format, as I think it will get initialized only once,
>> so it should persist. Somebody here should know about this.
> 

>> 
>> I have a remaining error (apart from the DOCTYPE not closing ">"):

I still cannot find where the DOCTYPE gets serialized (xalan?)
I'm very frustrated... but I'm beginning to understand :)

>> 
>> The synchronization in org.apache.avalon.util.JdbcConnectionPool is
>> broken. I was about to patch it, but a major code reorganization is
>> required, so I preferred to ask first.
>> 

In this connection pool there are serious race conditions (I have a SMP 
box to see these things happen before my customers :-).


>> I get Jdbc working until a moment when the a lot of connections get
>> removed from the pool (many more than created, according to the log) and
>> things fail after.
>> 


>> Index: org/apache/cocoon/serialization/AbstractTextSerializer.java
>> ===================================================================
>> RCS file: /home/cvspublic/xml-cocoon/src/org/apache/cocoon/serialization/Attic/AbstractTextSerializer.java,v
>> retrieving revision 1.1.2.8
>> diff -u -r1.1.2.8 AbstractTextSerializer.java
>> --- org/apache/cocoon/serialization/AbstractTextSerializer.java 2001/03/12 04:39:00
    1.1.2.8
>> +++ org/apache/cocoon/serialization/AbstractTextSerializer.java 2001/03/15 21:49:12
>> @@ -84,4 +84,14 @@
>>              format.put(OutputKeys.VERSION,version.getValue());
>>          }
>>      }
>> +
>> +    /**
>> +     * Recycle serializer by removing references
>> +     */
>> +    public void recycle() {
>> +        this.format = new Properties();

I'm not at all sure about the upper line, since format gets only 
initialized in init()... So the format will get lost?

>> +        super.recycle();
>> +    }


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message