cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Berin Loritsch <blorit...@apache.org>
Subject Re: [PATCH] Re: [C2][Xalan2] Xalan2J problems under heavy load using Apache JMeter
Date Thu, 15 Mar 2001 22:07:21 GMT
Santiago Gala wrote:
> 
> Scott_Boag@lotus.com wrote:
> 
> > Thanks Davanum.  I actually reproduced what I believe is the equivalent to
> > this bug last night.  So I'll keep working with that test, and then try
> > your add-department2 to verify that it is fixed.
> >
> > -scott
> >
> >
> 
> I have searched a little bit two bugs. The one commented here (maybe),
> and the problem with <!DOCTYPE not closing ">".
> 
> I found two problems in XMLSerializer:
> 
> - The serializer "wap", for WML and the XMLSerializer used in voiceML
> are in the same pool. So, funny things happen. If you hit first the
> hello.vml page, the .wml page works (without doctype). If it is the
> other way round, both fail because the WML DOCTYPE is not properly
> closed. I have no fix for this one, other than having different pools in
> Avalon to manage the serializers that have different properties.
> 
> - Following the chain of inheritance, I found that XMLSerializer fails
> to propagate .recycle() up. There is a missing class in the hierarchy.
> There is a intermediate class that does not implement Recyclable.
> 
> I used the following patch to ensure super is called. I'm not sure about
> reinitializing the format, as I think it will get initialized only once,
> so it should persist. Somebody here should know about this.

Thanks, Santiago.  Your patches have been applied.

> 
> It seems to solve some of the errors reported in this thread.
> 
> I have a remaining error (apart from the DOCTYPE not closing ">"):
> 
> The synchronization in org.apache.avalon.util.JdbcConnectionPool is
> broken. I was about to patch it, but a major code reorganization is
> required, so I preferred to ask first.
> 
> I get Jdbc working until a moment when the a lot of connections get
> removed from the pool (many more than created, according to the log) and
> things fail after.
> 
>   ------------------------------------------------------------------------------------------------------------------------------------
> ? org/apache/cocoon/serialization/WMLCSerializer.java
> Index: org/apache/cocoon/serialization/AbstractSerializer.java
> ===================================================================
> RCS file: /home/cvspublic/xml-cocoon/src/org/apache/cocoon/serialization/Attic/AbstractSerializer.java,v
> retrieving revision 1.1.2.11
> diff -u -r1.1.2.11 AbstractSerializer.java
> --- org/apache/cocoon/serialization/AbstractSerializer.java     2001/03/12 05:55:23 
   1.1.2.11
> +++ org/apache/cocoon/serialization/AbstractSerializer.java     2001/03/15 21:49:12
> @@ -47,6 +47,7 @@
>       * Recycle serializer by removing references
>       */
>      public void recycle() {
> +        super.recycle();
>          this.output = null;
>      }
>  }
> Index: org/apache/cocoon/serialization/AbstractTextSerializer.java
> ===================================================================
> RCS file: /home/cvspublic/xml-cocoon/src/org/apache/cocoon/serialization/Attic/AbstractTextSerializer.java,v
> retrieving revision 1.1.2.8
> diff -u -r1.1.2.8 AbstractTextSerializer.java
> --- org/apache/cocoon/serialization/AbstractTextSerializer.java 2001/03/12 04:39:00 
   1.1.2.8
> +++ org/apache/cocoon/serialization/AbstractTextSerializer.java 2001/03/15 21:49:12
> @@ -84,4 +84,14 @@
>              format.put(OutputKeys.VERSION,version.getValue());
>          }
>      }
> +
> +    /**
> +     * Recycle serializer by removing references
> +     */
> +    public void recycle() {
> +        this.format = new Properties();
> +        super.recycle();
> +    }
> +
> +
>  }
> Index: org/apache/cocoon/serialization/XMLSerializer.java
> ===================================================================
> RCS file: /home/cvspublic/xml-cocoon/src/org/apache/cocoon/serialization/Attic/XMLSerializer.java,v
> retrieving revision 1.1.2.17
> diff -u -r1.1.2.17 XMLSerializer.java
> --- org/apache/cocoon/serialization/XMLSerializer.java  2001/03/12 10:57:23     1.1.2.17
> +++ org/apache/cocoon/serialization/XMLSerializer.java  2001/03/15 21:49:12
> @@ -46,7 +46,7 @@
>      }
> 
>      /**
> -     * Recyce the serializer. GC instance variables
> +     * Recycle the serializer. GC instance variables
>       */
>      public void recycle() {
>          super.recycle();
> 
>   ------------------------------------------------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
> For additional commands, email: cocoon-dev-help@xml.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Mime
View raw message