cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santiago Gala <sg...@hisitech.com>
Subject [PATCH] My one bit contribution to cocoon2 (maybe it applies also to one?)
Date Sat, 03 Mar 2001 22:42:56 GMT
Hi to all.

Some of you already know me. I am Santiago Gala, contributor to
Jetspeed. I have recently subscribed to cocoon-dev to see how things are
going round here.


I have found a very small error (1 bit) in cocoon2 samples.

Also warn that my WAP phone is so dumb that it does not have the
copyright character in the charset (but it draws a nice whitespace
instead). Don't know about other phones, but maybe a change to "(c)"
would be interesting.

Also, the home /<webapp>/welcome is badly handled by the UP.Link to WML
translator version in Movistar, so that link to individual pages appear
as broken ( hello.wml -> welcome/hello.wml when browsing with the phone)

Maybe setting a <BASE href="/<webapp>/"> would help?

You can see my patch working in http://fw.intranet.hisitech.com/c2/hello.wml
(my ADSL is up!) Before I applied it, my phone ignored the action,
as there was no card called "About". Now it works.

BTW, 2.0a4 is great!

Here goes the patch. As you can see, it is worth exactly one bit of
change. :)

Index: page/simple-page2wml.xsl
===================================================================
RCS file:
/home/cvspublic/xml-cocoon/webapp/stylesheets/page/Attic/simple-page2wml.xsl,v
retrieving revision 1.1.2.2
diff -u -r1.1.2.2 simple-page2wml.xsl
--- page/simple-page2wml.xsl    2000/08/21 19:29:11     1.1.2.2
+++ page/simple-page2wml.xsl    2001/02/13 12:03:56
@@ -7,7 +7,7 @@
       <card id="index" title="{title}">
        <xsl:apply-templates select="content"/>
        <do type="accept" label="About">
-     <go href="#About"/>
+     <go href="#about"/>
        </do>
       </card>




Mime
View raw message