cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler" <cziege...@sundn.de>
Subject AW: [C2]: Component Pooling and recycling
Date Wed, 21 Feb 2001 13:15:34 GMT
> * Paul Russell wrote
>
> * Carsten Ziegeler (cziegeler@sundn.de) wrote :
> > > * Carsten Ziegeler (cziegeler@sundn.de) wrote :
> > > > I would suggest to change the behaviour of 3. and 4. that Recyclable
> > > > sitemap components are always recycled and that Poolable sitemap
> > > > components are alyways returned to the pool - regardless if they
> > > > declare PoolClient or not.
> > > How do you propose doing the last?
> > The ResourcePipeline currently gets the sitemap components out of the
> pool
> > and puts them back if they declare PoolClient. I would add at that point
> > an additional test for Poolable and Recyclable. The
> SitemapComponentSelector
> > must be extended by a put-method() for this.
> 
> Uhuh. Might make more sense to add the 'put' method to the
> CocoonComponentSelector, which is where all the pooling code seems to
> be.
> 
Ohh, yes the CocoonComponentSelector is the one.

> Other than that, I have no major problem with it. I still think the
> Avalon ComponentManager interface needs changing so that it contains a
> 'put' method, however. Anything that can 'compose' a component should be
> able to 'put' it back afterwards. Everything we're doing to get around
> this looks like a hack to me.
> 
Yes, exactly. This hacking is the reason why I am asking first - I thought that I perhaps
had overlooked something.

So I think, we should do the hack first and then when a corrected ComponentManager is available
we can remove it.

Carsten


Mime
View raw message