cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Herbert Hotz <herbert.h...@symmetrix.ch>
Subject Re: ESQL.XSL bug
Date Mon, 13 Nov 2000 01:37:51 GMT
Donald Ball wrote:

> thanks, forgot this in my revision. i patched it slightly differently, but
> thanks nonetheless. i also checked in some code for changing autocommit to
> false in case you want to try to execute a sequence of sql queries
> atomically.
>
> - donald

Hi Donald,

Thanks for your work regarding esql.xsl! I know, this baby is still not
born - but it is on the way, isn't it? However, learned a lot about
logicsheets 'how to'. Thanks again.

For this time, I have some suggestions for improvment of esql.xsl v1.31:

1) Bug: PrintWriter vs. StringWriter (did not compile) :-(

2) Bug: _esql_connection.connection.rollback(); (did not compile) :-(

3) IMHO <xsl:template match="esql:execute-query/esql:results" priority="2">
   needs some corrections, if it should comply to esql.xsd v1.1.

   Question: Why does this match clause have just ONE '/' opposed
             to all the other match clauses? Is it a question of
             cardinality?

4) FYI: One cannot set 'skip_rows' and 'max_rows' - but I'm sure you know!
        And what's about null-indicator?


See here the patches I suggest. Perhaps you have some better ideas to
reach the goals. Good luck!


diff esql.xsl.v1.31 esql.xsl.v1.31a
148c148
<     StringWriter _esql_exception_writer = null;
---
>     PrintWriter _esql_exception_writer = null;
287c287
<             _esql_connection.rollback();
---
>             _esql_connection.connection.rollback();
292c292
<             _esql_connection.rollback();
---
>             _esql_connection.connection.rollback();
321c321
<     <xsl:if test="esql:no-results">
---
>     <xsl:if test="../esql:no-results">
324c324
<           <xsl:apply-templates select="esql:no-results/*"/>
---
>           <xsl:apply-templates select="../esql:no-results/*"/>


Regards,
Herbert
--
+----------------------+-------------------------------------------+
| Herbert Hotz         | Voice:   +41 1 381 8880                   |
| Symmetrix AG         | Fax:     +41 1 381 2127                   |
| Muehle Tiefenbrunnen | GSM-SMS: +41 79 402 5704                  |
| Seefeldstrasse 231   | URL:     http://www.symmetrix.ch/         |
| CH-8008 Zurich       | E-Mail:  mailto:herbert.hotz@symmetrix.ch |
+----------------------+-------------------------------------------+


Mime
View raw message