Return-Path: <cziegeler@sundn.de>
Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Delivered-To: mailing list cocoon-dev@xml.apache.org
Received: (qmail 61398 invoked from network); 4 Oct 2000 11:36:10 -0000
Received: from sundn.pb.teuto.net (HELO viruswall.ynes.de) (212.8.194.130)
  by locus.apache.org with SMTP; 4 Oct 2000 11:36:10 -0000
Received: from 10.10.1.10 by viruswall.ynes.de (InterScan E-Mail VirusWall
 NT); Wed, 04 Oct 2000 13:35:41 +0200 (Westeuropaeische Sommerzeit)
Received: from hw0230 (fw-dmz.ynes.de [10.10.1.1])
	by mail.ynes.de (8.9.3/8.9.3/NoSpam) with SMTP id NAA21952
	for <cocoon-dev@xml.apache.org>; Wed, 4 Oct 2000 13:35:40 +0200
From: "Carsten Ziegeler" <cziegeler@sundn.de>
To: <cocoon-dev@xml.apache.org>
Subject: [C2]: Bug in SitemapHandler (Handler.java)
Date: Wed, 4 Oct 2000 13:41:01 +0200
Message-ID: <NEBBLPMLKKCJBKEOKNFHMEAJDBAA.cziegeler@sundn.de>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2910.0)
In-Reply-To: <39DA41FE.B02C015@apache.org>
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400
Importance: Normal
X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N

Hello,

creeping through the subsitemaps, I found this simple bug in the =
SitemapHandler (org.apache.cocoon.sitemap.Handler) Construtor:

    protected Handler (String source, boolean check_reload)
    throws FileNotFoundException {
        this.check_reload =3D check_reload;
        String s =3D null;
        if (source.charAt(source.length() - 1) =3D=3D =
File.separatorChar) {
            s =3D source + "sitemap.xmap";
            this.sourceFile =3D new File (s);
        } else {
            sourceFile =3D new File (source);
            if (!sourceFile.isFile()) {
                s =3D source + File.separatorChar + "sitemap.xmap";
                sourceFile =3D new File (s);
            }
!!! The following is not called, if "source" ends with the =
File.separatorChar:

            if (!sourceFile.canRead()) {
                throw new FileNotFoundException ("file " + s + " not =
found or cannot be opened for reading");
            }
        }
    }

I think the last lines should be read like this:
        }
        if (!sourceFile.canRead()) {
                throw new FileNotFoundException ("file " + s + " not =
found or cannot be opened for reading");
        }
    }

Regards
Carsten Ziegeler

Open Source Group              sunShine - Lighting up e:Business
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Carsten Ziegeler, S&N AG, Klingenderstrasse 5, D-33100 Paderborn
www.sundn.de                           mailto:cziegeler@sundn.de=20
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D