Return-Path: <per@onclave.com>
Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Delivered-To: mailing list cocoon-dev@xml.apache.org
Received: (qmail 68665 invoked from network); 17 Aug 2000 22:19:12 -0000
Received: from unknown (HELO onclave.com) (208.249.126.103)
  by locus.apache.org with SMTP; 17 Aug 2000 22:19:12 -0000
Received: from vader [151.204.64.143] by onclave.com with ESMTP
  (SMTPD32-6.00) id A5A0540250; Thu, 17 Aug 2000 18:22:24 -0400
From: "Per Kreipke" <per@onclave.com>
To: <cocoon-dev@xml.apache.org>
Subject: FEATURE? SQL taglib <sql:tag-case> element...
Date: Thu, 17 Aug 2000 18:18:31 -0400
Message-ID: <NDBBIKLOLMEELKELLPFIMELECLAA.per@onclave.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2910.0)
Importance: Normal
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400
X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N

Two observations about attribute names when using the SQL taglib.
Given the following SQL XSP snippet:

<?cocoon-process type="xsp"?>
<xsp:page
  language="java"
  xmlns:sql="http://www.apache.org/1999/SQL"
  xmlns:xsp="http://www.apache.org/1999/XSP/Core"
>
<sql:execute-query>
	...
	<sql:doc-element>tasks</sql:doc-element>
	<sql:row-element>task</sql:row-element>
	<sql:tag-case>lower</sql:tag-case>
	<sql:null-indicator>yes</sql:null-indicator>
	<sql:id-attribute>ID</sql:id-attribute>
	...
</sql:execute-query>


1. Even though the tag-case value is 'lower', the attribute name for ID in
the task row is still uppercase. An obvious mistake on my part, and it might
not be a bug since it's clearly 'tag-case' not 'attribute-case'. However...


2. The null indicator attribute name is 'NULL' and I have no control over
either its case or the name itself. That doesn't seem consistent to me (even
thought the doc page does say that the attribute will be NULL="yes"). I
might want to have it renamed to match other data/styles in my formatter.

Just having started with Cocoon it took me a day to figure out the problem
because I was looking at the results in IE5 in HTML form (e.g. I didn't know
about <?cocoon-format type="text/xml"?>). IE5 changes the ID tag to lower
case. Seeing the XML showed me the actual case of the attributes.


Suggestions:

- Let tag-case specify the attribute case as well -or- add an
<sql:attribute-case> element.

- Change the <sql:null-indicator> element to accept any value. If missing,
empty or 'Y' or 'yes', output NULL="yes". If anything else, use the element
value as the name.

Example:

The following add the attribute/value pair NULL="yes" to null items:
<sql:null-indicator/>
<sql:null-indicator>yes</sql:null-indicator>
<sql:null-indicator>Y</sql:null-indicator>
<sql:null-indicator>NULL</sql:null-indicator>

The following add the attribute/value pair xxx="yes" to null items:
<sql:null-indicator>xxx</sql:null-indicator>

If <sql:null-indicator> is not given, null items are skipped.

Per.