cocoon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giacomo Pati <Giacomo.P...@pwr.ch>
Subject Re: org.apache.cocoon.sitemap.SitemapManager.hasChaged()
Date Fri, 25 Aug 2000 20:31:02 GMT
Stefano Mazzocchi wrote:
> 
> Vadim Gritsenko wrote:
> >
> > Hi All,
> >
> > It seems there is error in this method. It returns "true"
> > always now, and I think it should return false sometimes,
> > like this:
> >
> >  public boolean hasChanged () {
> >   SitemapHandler sitemapHandler = null;
> >   Enumeration enum = sitemaps.elements();
> >   while (enum.hasMoreElements()) {
> >    sitemapHandler = (SitemapHandler) enum.nextElement ();
> >    if (sitemapHandler != null) {
> >     if (sitemapHandler.hasChanged())
> >      return true;
> >    }
> >   }
> >   return false;
> >  }
> 
> Good catch. Patch applied.

I've commited it right now !?!

> 
> BTW, people, the use of "Vector", "Stack", "Hashtable" and "Enumerator"
> is to be considered deprecated for a number of reasons:

Ok, I knew that but I'll check again the code I've written ASAP.

Giacomo

-- 
PWR GmbH, Organisation & Entwicklung      Tel:   +41 (0)1 856 2202
Giacomo Pati, CTO/CEO                     Fax:   +41 (0)1 856 2201
Hintereichenstrasse 7                     Mailto:Giacomo.Pati@pwr.ch
CH-8166 Niederweningen                    Web:   http://www.pwr.ch

Mime
View raw message