Return-Path: <uli@niedermann.bb.bawue.de>
Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Delivered-To: mailing list cocoon-dev@xml.apache.org
Received: (qmail 24342 invoked from network); 22 Jun 2000 17:55:11 -0000
Received: from bender.bawue.de (postfix@193.197.13.1)
  by locus.apache.org with SMTP; 22 Jun 2000 17:55:11 -0000
Received: from eisbaer.bb.bawue.de (eisbaer.bb.bawue.de [193.197.13.2])
	by bender.bawue.de (Postfix) with ESMTP id D051086E
	for <cocoon-dev@xml.apache.org>; Thu, 22 Jun 2000 19:54:56 +0200 (CEST)
Received: (from uucp@localhost)
	by eisbaer.bb.bawue.de (8.9.3/8.9.3) with UUCP id TAA20419
	for cocoon-dev@xml.apache.org; Thu, 22 Jun 2000 19:55:08 +0200
Received: (from uli@localhost)
	by niedermann.bb.bawue.de (8.9.3/8.9.3) id TAA02424;
	Thu, 22 Jun 2000 19:55:52 +0200
To: cocoon-dev@xml.apache.org
Subject: Re: CVS fails to build...
References: <s9521f36.087@experian.com>
In-Reply-To: John Morrison's message of "Thu, 22 Jun 2000 14:13:24 +0000"
From: Hans Ulrich Niedermann <niedermann@isd.uni-stuttgart.de>
Date: 22 Jun 2000 19:55:52 +0200
Message-ID: <m2em5p8us7.fsf@niedermann.bb.bawue.de>
Lines: 38
User-Agent: Gnus/5.0806 (Gnus v5.8.6) XEmacs/21.1 (Bryce Canyon)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: uli@niedermann.bb.bawue.de
X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N

John Morrison <john.morrison@experian.com> writes:

> There's a close bracket missing at the end of  line 370 in
> org.apache.cocoon.Engine for Cocoon 1

You're right. My patch included the missing bracket, but somehow
Stefano seems to have forgotten it when patching. Patch attached.

Uli

Index: src/org/apache/cocoon/Engine.java
===================================================================
RCS file: /home/cvspublic/xml-cocoon/src/org/apache/cocoon/Engine.java,v
retrieving revision 1.31
diff -c -r1.31 Engine.java
*** src/org/apache/cocoon/Engine.java	2000/06/21 22:09:56	1.31
--- src/org/apache/cocoon/Engine.java	2000/06/22 17:49:08
***************
*** 365,373 ****
              out.println(page.getContent());
  
              // if verbose mode is on the the output type allows it
! 			         // and the HTTP request isn't a HEAD
              // print some processing info as a comment
!             if (VERBOSE && (page.isText()) && !"HEAD".equals(request.getMethod()) {
                  time = System.currentTimeMillis() - time;
                  out.println("<!-- This page was served "
                      + (page.isCached() ? "from cache " : "")
--- 365,373 ----
              out.println(page.getContent());
  
              // if verbose mode is on the the output type allows it
!             // and the HTTP request isn't a HEAD
              // print some processing info as a comment
!             if ( VERBOSE && (page.isText()) && !"HEAD".equals(request.getMethod()) ) {
                  time = System.currentTimeMillis() - time;
                  out.println("<!-- This page was served "
                      + (page.isCached() ? "from cache " : "")