Return-Path: <esalon@canuck.com>
Mailing-List: contact cocoon-dev-help@xml.apache.org; run by ezmlm
Delivered-To: mailing list cocoon-dev@xml.apache.org
Received: (qmail 25171 invoked from network); 22 Jun 2000 21:45:59 -0000
Received: from the-gimp.canuck.com (HELO canuck.com) (204.50.15.12)
  by locus.apache.org with SMTP; 22 Jun 2000 21:45:59 -0000
Received: from [62.155.169.183] (p3E9BA9B7.dip.t-dialin.net [62.155.169.183])
	by canuck.com (8.9.3/8.9.1) with ESMTP id PAA2093427
	for <cocoon-dev@xml.apache.org>; Thu, 22 Jun 2000 15:45:40 -0600 (MDT)
User-Agent: Microsoft Outlook Express Macintosh Edition - 5.01 (1630)
Date: Thu, 22 Jun 2000 23:45:57 +0200
Subject: Re: cvs commit:
	xml-cocoon/src/org/apache/cocoon/processor/xsp/library/sql
	XSPSQLLibrary.java
From: Mark Washeim <esalon@canuck.com>
To: <cocoon-dev@xml.apache.org>
Message-ID: <B57855B5.18BF%esalon@canuck.com>
In-Reply-To: <20000622194922.31246.qmail@locus.apache.org>
Mime-version: 1.0
Content-type: text/plain; charset="US-ASCII"
Content-transfer-encoding: 7bit
X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N

on 22/6/00 9:49 pm, balld@locus.apache.org at balld@locus.apache.org wrote:

> balld       00/06/22 12:49:20
> 
> Modified:    src/org/apache/cocoon/processor/xsp/library/sql
> XSPSQLLibrary.java
> Log:
> update-rows-attribute is no longer mandatory for updates
> 
> Revision  Changes    Path
> 1.8       +2 -2  
> xml-cocoon/src/org/apache/cocoon/processor/xsp/library/sql/XSPSQLLibrary.java
> 
> Index: XSPSQLLibrary.java
> ===================================================================
> RCS file: 
> /home/cvs/xml-cocoon/src/org/apache/cocoon/processor/xsp/library/sql/XSPSQLLib
> rary.java,v
> retrieving revision 1.7
> retrieving revision 1.8
> diff -u -r1.7 -r1.8
> --- XSPSQLLibrary.java 2000/05/16 20:01:06 1.7
> +++ XSPSQLLibrary.java 2000/06/22 19:49:18 1.8
> @@ -60,7 +60,7 @@
> * A processor that performs SQL database queries.
> *
> * @author <a href="mailto:balld@webslingerZ.com">Donald Ball</a>
> - * @version $Revision: 1.7 $ $Date: 2000/05/16 20:01:06 $
> + * @version $Revision: 1.8 $ $Date: 2000/06/22 19:49:18 $
> */
> 
> public class XSPSQLLibrary {
> @@ -143,7 +143,7 @@
> if (!st.execute(query)) {
> /** this returns the number of rows we updated, or -1 on error **/
> int update_rows = st.getUpdateCount();
> -            if (results_element != null) {
> +            if (results_element != null && !"".equals(update_rows_attribute))
> {
> results_element.setAttribute(update_rows_attribute,""+update_rows);
> }
> } else {
> 
> 
> 
> 
> ----------------------------------------------------------------------
> In case of troubles, e-mail:     webmaster@xml.apache.org
> To unsubscribe, e-mail:          cocoon-cvs-unsubscribe@xml.apache.org
> For additional commands, e-mail: cocoon-cvs-help@xml.apache.org
> 

Thanks!

Though, it actually makes a great deal of sense. Namely, unless you're
planning on executing the sql 'manually', you need something in the response
that 'tersely' expresses sucess. Or so I'm lead to believe in playing with
this... thanks for you work on it, it's GREAT!



-- 
Mark (Poetaster) Washeim

'On the linen wrappings of certain mummified remains
found near the Etrurian coast are invaluable writings
that await translation.

Quem colorem habet sapientia?'

Evan S. Connell